Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

atom --wait doesn't wait #3074

Closed
xori opened this issue Jul 24, 2014 · 35 comments
Closed

atom --wait doesn't wait #3074

xori opened this issue Jul 24, 2014 · 35 comments
Labels
atom bug linux Issues that occur on Linux but not on other platforms. windows Issues that occur on Windows but not on other platforms.

Comments

@xori
Copy link

xori commented Jul 24, 2014

Version 0.118.0 on Windows 7 x64

PS C:\ > atom --wait myfile.txt

Immediately terminates, but does continue to open the file. Expected result is to wait until the file is closed in the editor.

https://github.com/atom/language-git
and
http://blog.atom.io/2014/03/13/git-integration.html
say that the syntax that I'm using is correct. Is there a new syntax to enable this or is this feature no longer supported.

@kevinsawicki
Copy link
Contributor

This is definitely supported, it just doesn't appear to be working on Windows currently, sorry for the confusion.

@xori
Copy link
Author

xori commented Aug 18, 2014

just an update that this is still occuring in v0.123.0

@toholio
Copy link

toholio commented Aug 19, 2014

Noticed the same thing. Glad it's not just me misconfiguring things. I'm using another editor for git commit messages and the like for the time being.

@DanHarman
Copy link

Just found this too. Still broken in v0.124.0

@tolu
Copy link

tolu commented Sep 23, 2014

Still broken in v0.130.0

@xori
Copy link
Author

xori commented Sep 29, 2014

oddly enough in Powershell I can do
start-process -wait atom
and the shell behaves correctly. Though I still can't seem to use this to write my git commit messages.

@kalch
Copy link

kalch commented Oct 26, 2014

Still broken v0.139.0

@screendriver
Copy link

+1 same here

@mletterle
Copy link

Just confirming that it's still an issue in v0.141.0

@mark-hahn
Copy link
Contributor

I'm seeing the opposite problem as of 146. I don't want it to wait but it is waiting. See #4178

@anaisbetts
Copy link
Contributor

@kevinsawicki You should probably steal the Update.com trick from me - all you need to do is copy that file in as atom.com and it'll work

@christophfroehlich
Copy link

on Mac OS X 10.9.5 and atom.io 0.152 I have the same problem!

@steveoh
Copy link

steveoh commented Dec 2, 2014

152 on windows. 👎 not waiting.

@jimgraham
Copy link
Contributor

Can't use Atom for git config --global core.editor until this is fixed 👎

@pyvelepor
Copy link

I confirmed that paulcbett's Update.com -> atom.com trick is a good workaround until this is fixed. If you installed Atom using Chocolatey, you'll need to modify your PATH environment variable to ensure that the parent directory of atom.com appears before the path used by Chocolatey. If you're able to, appending it to PATH should work.

@mark-hahn
Copy link
Contributor

This problem went away for me in a recent atom version.

On Tue, Dec 23, 2014 at 5:55 AM, crobinsonut notifications@github.com
wrote:

I confirmed that paulcbett's Update.com -> atom.com trick is a good
workaround until this is fixed. If you installed Atom using Chocolatey,
you'll need to modify your PATH environment variable to ensure that the
parent directory of atom.com appears before the path used by Chocolatey.
If you're able to, appending it to PATH should work.


Reply to this email directly or view it on GitHub
#3074 (comment).

@mark-hahn
Copy link
Contributor

P.S. I switched to the installer from chocolately. Try that. Be sure to
follow the blog instructions.

On Tue, Dec 23, 2014 at 9:54 AM, Mark Hahn mark@hahnca.com wrote:

This problem went away for me in a recent atom version.

On Tue, Dec 23, 2014 at 5:55 AM, crobinsonut notifications@github.com
wrote:

I confirmed that paulcbett's Update.com -> atom.com trick is a good
workaround until this is fixed. If you installed Atom using Chocolatey,
you'll need to modify your PATH environment variable to ensure that the
parent directory of atom.com appears before the path used by Chocolatey.
If you're able to, appending it to PATH should work.


Reply to this email directly or view it on GitHub
#3074 (comment).

@raphinesse
Copy link

Works for me with the Installer version for Windows (Atom 0.165.0) 👍

@jimgraham
Copy link
Contributor

For me, it waits if launching atom for the first time, but does not wait the second time. This seems to be the reverse behaviour of #4178 (comment)

Atom 0.165.0, Windows 7 SP1 x64

From the command line

  • atom --wait
    • See the following in the DOS box
C:\Users>atom --wait
App load time: 156ms
[8492:1230/141025:INFO:renderer_main.cc(204)] Renderer process started
[8704:1230/141026:INFO:CONSOLE(64)] "Window load time: 1174ms", source: file:///C:/Users/Jim/AppData/Local/atom/app-0.165.0/resources/app/static/index.js (64)
<prompt waits here until atom is closed>
  • With no instances of atom running, start atom from shortcut or Start menu, leave it running.
  • From the command line, start a second atom editor with atom --wait
    • see the following in DOS box
C:\Users>atom --wait
App load time: 156ms
C:\Users>

This is problematic because if one does work in Atom (long running) but then configures atom --wait as one's git commit editor, it won't work.

@jordao76
Copy link

I think that the correct way to use atom for git commit is: atom --new-window --wait. This way, it opens a new window and shouldn't interfere with a currently running instance.

But, if I already have a running instance, the new window is opened, but the command won't wait. So, this is still a bug. I'm using 0.190.0.

So, to reproduce:

  1. Run atom, this opens atom and doesn't wait, which is OK
  2. Run atom -n -w, this opens a new atom window but doesn't wait, which is not OK

Note that doing step 2 alone works.

@ccoenen
Copy link

ccoenen commented Apr 16, 2015

What if --wait would imply --new-window? I can't really think of a use case, where i would want to edit something in an existing editor and then wait around until that one gets closed.

If this is / should be the case already, just ignore my message

@jordao76
Copy link

I think you're right! It looks like it implies that already. So no need for --new-window...

@50Wliu 50Wliu added the linux Issues that occur on Linux but not on other platforms. label Jun 11, 2015
@robnext9981
Copy link

I've got the same strange behavior as @jordao76 explained.
Really annoying for newbie...I've got to change default editor 😟
Here's my dev environment :
Atom 0.209.0, Windows 7 Professional SP1 x64

@jacaseyclyde
Copy link

Still happening in v1.0.2. guess i'll jsut have to use npp for commits for now
Edit: running on Windows 8.1

@robnasby
Copy link

This is an issue for me as well on Atom v1.0.2, running on WIndows 7 x64. Git opens Atom for interactive rebase, etc. but doesn't wait. I've tried --wait and --new-window --wait, without luck.

@oomlaut
Copy link

oomlaut commented Jul 31, 2015

Using 1.0.3 on Windows 7. Experiencing this issue only when Atom is already running.

@bendkt
Copy link

bendkt commented Aug 13, 2015

1.0.7 on Windows 8.1 -> same problem

@collinjackson93
Copy link

Using 1.0.10 on Windows 10. I have this issue regardless if Atom is already running or not.

@Zooce
Copy link

Zooce commented Sep 4, 2015

Still an issue on 1.0.11 on Windows 7 x64... both atom -w and atom -w -n work fine if Atom isn't currently running, otherwise it fails ("Aborting commit due to empty commit message.")

@abhisekp
Copy link

+1

I've the same issue in Win 7 SP1 x64 using Atom 1.0.11

With a running atom editor instance, I tried with the following, but to no success. 😟

  • atom --foreground
  • atom --wait
  • atom --wait --new-window
  • atom --wait --foreground
  • atom --wait --new-window --foreground

The process didn't wait.

@abhisekp
Copy link

@paulcbetts could you please explain about the update.com trick?

@unguiculus
Copy link

Same here. Only works if Atom isn't already running.

@bijeebuss
Copy link

+1

@mnquintana
Copy link
Contributor

Thanks for the feedback everyone! However, all these +1s and 👍s are just adding noise, so to minimize that I'm going to lock this issue for now – we may unlock it once someone starts working on this enhancement to get further feedback.

@atom atom locked and limited conversation to collaborators Sep 17, 2015
@50Wliu
Copy link
Contributor

50Wliu commented Feb 4, 2016

This has been fixed and should be out in Atom 1.6.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
atom bug linux Issues that occur on Linux but not on other platforms. windows Issues that occur on Windows but not on other platforms.
Projects
None yet
Development

No branches or pull requests