New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: add crash restore #4161

Closed
darkdragon-001 opened this Issue Nov 12, 2014 · 30 comments

Comments

Projects
None yet
@darkdragon-001
Copy link

darkdragon-001 commented Nov 12, 2014

Today my Atom crashed and I realized that there is no such thing as restore your unsaved work.
Since this is more than standard nowadays - please add this!

@alexandernst

This comment has been minimized.

Copy link

alexandernst commented Nov 12, 2014

+1

@benogle

This comment has been minimized.

Copy link
Contributor

benogle commented Nov 12, 2014

@darkdragon-001 Did you report the crash? If on OSX, you can open the Console app, and look for atom crash log. Paste it into a new issue.

If not on osx, what System are you on? Version of atom?

Rather than investing in crash recovery, I'd rather it didnt crash at all.

@alexandernst

This comment has been minimized.

Copy link

alexandernst commented Nov 12, 2014

@benogle There is no such thing as a crash-free application, just a rare-crashes application, and not before tons of time spent on debugging, patching and tracking. That's why a "restore my unsaved buffers on crash/accidental quit" is a must-have.

@benogle

This comment has been minimized.

Copy link
Contributor

benogle commented Nov 12, 2014

Very very infrequently then ;). A crash report from @darkdragon-001 would be very helpful.

@darkdragon-001

This comment has been minimized.

Copy link
Author

darkdragon-001 commented Nov 12, 2014

Actually this time it was not Atom's fault. My whole system froze because of a different reason - so I had to hardly restart my computer...

This is only one reason for a crash recovery. But I think there are others and therefore it is worth building it. Should not me too difficult to regularly save the current state in a temporary file. And also should not slow something down. And code files are not big, so this is also no issue.
So you can only win by implementing this feature!

@lee-dohm

This comment has been minimized.

Copy link
Member

lee-dohm commented Nov 13, 2014

Sounds like you want the live-archive package.

I also feel like this is a duplicate of #1601?

@mark-hahn

This comment has been minimized.

Copy link
Contributor

mark-hahn commented Nov 13, 2014

As the author of live-archive I hate to say it won't help. It only
archives a file when it is saved. So the file wouldn't be lost in any
case. Originally I was thinking of archiving on every long pause but
decided it wasn't necessary. Maybe that should be an option.

On Wed, Nov 12, 2014 at 8:45 PM, Lee Dohm notifications@github.com wrote:

Sounds like you want the live-archive package
https://atom.io/packages/live-archive.

I also feel like this is a duplicate of #1601
#1601?


Reply to this email directly or view it on GitHub
#4161 (comment).

@1j01

This comment has been minimized.

Copy link

1j01 commented Dec 29, 2014

Power outages, accidental unplugs, large files (???), 73 KB files (just crashed for me with a weird font and large font size), broken packages, issues that will never be known til the end of time, Microsoft® Windows®, accidentally clicking the close button, siblings clicking the close button, ragequiting and then immediately realizing what you were doing wrong, spontaneous explosions, nuclear fission, and of course lots of crashes

This is a must-have.

Did I mention Microsoft Windows? It automatically restarts your computer to install updates.

@mark-hahn

This comment has been minimized.

Copy link
Contributor

mark-hahn commented Dec 29, 2014

How would automatically saving on every change work for you? That is the
way webstorm works and I loved it. I've been thinking of doing a package.

Change would be defined by a period of inactivity for some time, like 2 sec.

On Sun, Dec 28, 2014 at 11:05 PM, Isaiah Odhner notifications@github.com
wrote:

Power outages, accidental unplugs, large files (???
#307), 73 KB files (just crashed for
me with a weird font and large font size), broken packages, issues that
will never be known til the end of time, Microsoft® Windows®, accidentally
clicking the close button, siblings clicking the close button, ragequiting
and then immediately realizing what you were doing wrong, spontaneous
explosions, nuclear fission
https://en.wikipedia.org/wiki/Splitting_the_atom, and of course lots
https://github.com/atom/atom/issues?q=crash of crashes
https://github.com/atom/atom/labels/crash

This is a must-have.

Did I mention Microsoft Windows? It automatically restarts your computer
to install updates.


Reply to this email directly or view it on GitHub
#4161 (comment).

@1j01

This comment has been minimized.

Copy link

1j01 commented Jan 1, 2015

Ideally there should never be a time where your changes aren't saved or at least safe. Scratch does this nicely. It's actually like you just edit the file when you edit a file. There's no unsaved state, and you can just undo when you need to. I find this is a much better model for editors to have. It still makes sense to back up the original (which git does for you of course).
At any rate, there's no excuse for not having crash handling.

@hyiltiz

This comment has been minimized.

Copy link

hyiltiz commented Jan 12, 2015

Thought we already have that in Atom. If not yet (such as now), it really is a must.

@1j01

This comment has been minimized.

Copy link

1j01 commented Jan 25, 2015

Atom has crashed at least 5 times, in several different ways since I've last commented.

@jaxzin

This comment has been minimized.

Copy link

jaxzin commented Jun 11, 2015

+1 here, lost an unsaved buffer and was surprised Atom didn't have this feature. Seems a pretty standard in other popular text editors, so much so that I assumed Atom had it until it burned me.

@alexchandel

This comment has been minimized.

Copy link
Contributor

alexchandel commented Jun 13, 2015

👍 How it is possible that atom is almost 1.0 and STILL doesn't have this? If 1.0 is released without supporting unsaved buffers, then atom is a lie. It's just not safe to edit documents when your computer could kernel panic, power down, or–in the case of Windows–forcibly shut you down to install updates, unless your text editor protects you by restoring its previous state. ST does this. IDEs do this. Literally all OS X NSDocument apps do this. Even internet browsers do this.

@alexchandel alexchandel referenced this issue Jun 13, 2015

Closed

Atom 1.0 #3684

18 of 25 tasks complete
@50Wliu

This comment has been minimized.

Copy link
Member

50Wliu commented Jun 13, 2015

How it is possible that atom is almost 1.0 and STILL doesn't have this

It's on the 1.0 roadmap, so this should be addressed soon (especially since window restoring was added a few versions ago, but I'm not a member of the Atom team so I can't guarantee that). Just because Atom is almost at 1.0 doesn't mean it is at 1.0.

@benogle

This comment has been minimized.

Copy link
Contributor

benogle commented Jun 15, 2015

We wont be able to get to this in the next couple weeks, but it is still on the list. It will have to go in after 1.0.

@alexandernst

This comment has been minimized.

Copy link

alexandernst commented Jun 15, 2015

@benogle I'd say Atom's team should rather adapt the 1.0 release to the remaining critical tasks instead of the announced release date.

@benogle

This comment has been minimized.

Copy link
Contributor

benogle commented Jun 15, 2015

It's same same. If we declared 1.0 today or in 2 months, this would likely get done in the same time frame.

@alexandernst

This comment has been minimized.

Copy link

alexandernst commented Jun 15, 2015

If the critical pre-1.0 tasks list is that big for you to say that (and exclude from it such a critical task), I think the team should seriously reconsider the release date.

@dejj

This comment has been minimized.

Copy link

dejj commented Jun 26, 2015

+1 Heard of Atom.io today; amazed. First thing I try is killing it with unsaved changes; found this page; disappointed. Not switching from SublimeText. Maybe I'll be checking back in a few months.

@ivanmayes

This comment has been minimized.

Copy link

ivanmayes commented Jun 26, 2015

+1

@SpainTrain

This comment has been minimized.

Copy link

SpainTrain commented Jul 14, 2015

👍 Agree on this being a critical feature for any serious text editor. Assumed this was a feature and just lost some work due to Atom-unrelated system event. sad 🐼

@mlms13

This comment has been minimized.

Copy link

mlms13 commented Jul 14, 2015

👍 Just lost an unsaved todo list when atom became unresponsive. Without it, I'm now aimless and confused.

@pareeohnos

This comment has been minimized.

Copy link

pareeohnos commented Jul 16, 2015

👍 badly need this! I often (stupidly) keep a list of things I need to do in a new tab that I don't save given how temporary it is. Just had atom lock up due to a minified JS file having too long of a line (another bug I believe). It then prompted me to either keep waiting, or shut so I shut. When it returned, I lost my temporary files. This is a desperately needed feature!!

@Sogl

This comment has been minimized.

Copy link

Sogl commented Jul 29, 2015

+1
need this!

@batjko

This comment has been minimized.

Copy link
Contributor

batjko commented Jul 29, 2015

@Sogl and all: Looks like this ticket is now on the roadmap for a quality improvement push (see #7995 as linked by @benogle).

No further +1s necessary ;)

@Eutropia

This comment has been minimized.

Copy link

Eutropia commented Nov 5, 2015

was literally putting the finishing touches on a sonnet in fourteens for the love of my life and (surprise surprise) the mac crashes. Then I found out atom doesn't have a temp file buffer.

@1j01

This comment has been minimized.

Copy link

1j01 commented Nov 8, 2015

No further +1s necessary ;)

but that issue was closed, so how about a

This is the most important issue with Atom.

At least save things somewhere while you're editing them.

@50Wliu

This comment has been minimized.

Copy link
Member

50Wliu commented Nov 8, 2015

Ok. At this point there's not much constructive discussion happening, so I'm going to lock this issue. Updates will still be posted here as they appear. I'd also like to remind everyone that while the Quality Initiative may have ended, this issue is still open and is still on the post-1.0 roadmap.

@50Wliu 50Wliu closed this Nov 8, 2015

@50Wliu 50Wliu reopened this Nov 8, 2015

@atom atom locked and limited conversation to collaborators Nov 8, 2015

@50Wliu

This comment has been minimized.

Copy link
Member

50Wliu commented Feb 16, 2016

#10605 has been merged and at the current pace of development crash restore should be available in Atom 1.7.0!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.