-
Notifications
You must be signed in to change notification settings - Fork 17.4k
Exclude VCS Ignored Paths Toggle Not Respected #4203
Comments
There is! And that works. Why would there be two, one in Core Settings and one in Tree View preferences? Must they both be off? Or does Tree View override Core Settings? |
|
if What does |
Tree View is affected by the tree view setting. Fuzzy Finder et al are affected by the core setting. I didn't see that the screen shot referred to the Tree a view setting and got them reversed in my head.
|
OK. So why wouldn't Tree View respect the Core Setting and instead, need its own switch? |
Because some people don't want to show ignored files in the Tree View but still want to open them with the Fuzzy Finder and vice versa. |
I can see that. Does it make sense then to have a Core Settings option at all? Would it be better to let each package set its options as it needs? |
What packages would those be other than Tree View? |
You mentioned Fuzzy Finder. I would imagine there could be more in the future, too. |
Yes, there could be. But all the ones that currently exist people want to change together other than Tree View. Until there is another that people want to change separately, the current system is the best solution.
|
Of course, this is ultimately a design decision. My input would be that a global setting should be expected to affect everything. If the setting needs to be controlled by individual packages, there should be no global setting. Or the package settings must clearly show how they override the global setting. If I turn off the hiding of VCS ignored files in the Core Settings, it should be off for all packages. Or I can turn it on globally and let packages override that for their own features. |
Having it only as an AND is arbitrary. If you did that you should also It is customary to have a "use global" setting in the package instead. On Tue, Nov 18, 2014 at 5:06 AM, Bob Rockefeller notifications@github.com
|
Just wanted to chime in and say that I had this same problem and I found the two-settings piece pretty confusing. I just figured that the core "Hide VCS" button was broken (and I didn't know why the # of files being searched went way up). Took me about a week of irritation before I found this thread and got everything set correctly. Maybe the UX could be improved by moving the Hide VCS setting down to the plugin layer for everything. At least adding some description text to the core settings, similar to the text for the symlinks setting ("Used when searching and when opening files with the fuzzy finder"), would make it more clear what is affected by it. |
Seems like there might still be an issue related to this. My search/replace and cmd-p search box is honoring the 'exclude vcs ignored paths' being off but, on the directory browser pane the directory is invisible. |
As mentioned above, @steve-ross, the tree-view has its own setting for whether to display or not display VCS ignored files. |
I also found this very confusing. Luckily this thread showed up on a google search. The current behavior is not intuitive at all. Edit: I think that in the very least, the setting in tree-view should default to off. That way at least you would have to know about the setting to end up in a state where your files are not showing up. |
I second @joshontheweb in this. The default ON of the tree-view setting is wrong in my opinion. This was way too confusing. By the way I'm pretty sure the default of the Settings' "Exclude VCS Ignore Paths" was OFF but somehow it had turned on by itself?! |
This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks! |
If I switch off the Exclude VCS Ignored Paths option in my preferences, paths and files in my .gitignore file are still excluded from the tree view. I don't want that.
The text was updated successfully, but these errors were encountered: