Exclude VCS Ignored Paths Toggle Not Respected

[bobrocke]

If I switch off the Exclude VCS Ignored Paths option in my preferences, paths and files in my .gitignore file are still excluded from the tree view. I don't want that.

[benogle]

There is another setting in the tree view settings called 'Hide VCS Ignored files'

[bobrocke]

There is! And that works.

Why would there be two, one in Core Settings and one in Tree View preferences?

Must they both be off? Or does Tree View override Core Settings?

[lee-dohm]

Hide Vcs Ignored Files is respected by more than just the Tree View package. It is also respected by the Fuzzy Finder and potentially any other package that offers similar functionality. This is why there are separate settings.

[bobrocke]

if Hide Vcs Ignored Files affects other packages, why is the option in the Tree View package instead of Core Settings?

What does Exclude VCS Ignored Paths in Core Settings control?

[lee-dohm]

Tree View is affected by the tree view setting. Fuzzy Finder et al are affected by the core setting. I didn't see that the screen shot referred to the Tree a view setting and got them reversed in my head.

On Nov 16, 2014, at 5:29 PM, Bob Rockefeller notifications@github.com wrote:

if Hide Vcs Ignored Files affects other packages, why is the option in the Tree View package instead of Core Settings?

What does Exclude VCS Ignored Paths in Core Settings control?

—
Reply to this email directly or view it on GitHub.

[bobrocke]

OK.

So why wouldn't Tree View respect the Core Setting and instead, need its own switch?

[lee-dohm]

Because some people don't want to show ignored files in the Tree View but still want to open them with the Fuzzy Finder and vice versa.

[bobrocke]

I can see that.

Does it make sense then to have a Core Settings option at all? Would it be better to let each package set its options as it needs?

[lee-dohm]

What packages would those be other than Tree View?

[bobrocke]

You mentioned Fuzzy Finder. I would imagine there could be more in the future, too.

[lee-dohm]

Yes, there could be. But all the ones that currently exist people want to change together other than Tree View. Until there is another that people want to change separately, the current system is the best solution.

On Nov 17, 2014, at 1:09 PM, Bob Rockefeller notifications@github.com wrote:

You mentioned Fuzzy Finder. I would imagine there could be more in the future, too.

—
Reply to this email directly or view it on GitHub.

[bobrocke]

Of course, this is ultimately a design decision.

My input would be that a global setting should be expected to affect everything. If the setting needs to be controlled by individual packages, there should be no global setting.

Or the package settings must clearly show how they override the global setting.

If I turn off the hiding of VCS ignored files in the Core Settings, it should be off for all packages. Or I can turn it on globally and let packages override that for their own features.

[mark-hahn]

If I turn off the hiding of VCS ignored files in the Core Settings, it
should be off for all packages. Or I can turn it on globally and let
packages override that for their own features.

Having it only as an AND is arbitrary. If you did that you should also
support OR.

It is customary to have a "use global" setting in the package instead.

On Tue, Nov 18, 2014 at 5:06 AM, Bob Rockefeller notifications@github.com
wrote:

Of course, this is ultimately a design decision.

My input would be that a global setting should be expected to affect
everything. If the setting needs to be controlled by individual packages,
there should be no global setting.

Or the package settings must clearly show how they override the global
setting.

If I turn off the hiding of VCS ignored files in the Core Settings, it
should be off for all packages. Or I can turn it on globally and let
packages override that for their own features.

—
Reply to this email directly or view it on GitHub
#4203 (comment).