New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude VCS Ignored Paths Toggle Not Respected #4203

Closed
bobrocke opened this Issue Nov 16, 2014 · 19 comments

Comments

Projects
None yet
8 participants
@bobrocke

If I switch off the Exclude VCS Ignored Paths option in my preferences, paths and files in my .gitignore file are still excluded from the tree view. I don't want that.

@benogle

This comment has been minimized.

Show comment
Hide comment
@benogle

benogle Nov 16, 2014

Contributor

There is another setting in the tree view settings called 'Hide VCS Ignored files'

screen shot 2014-11-16 at 9 25 26 am

Contributor

benogle commented Nov 16, 2014

There is another setting in the tree view settings called 'Hide VCS Ignored files'

screen shot 2014-11-16 at 9 25 26 am

@benogle benogle closed this Nov 16, 2014

@bobrocke

This comment has been minimized.

Show comment
Hide comment
@bobrocke

bobrocke Nov 16, 2014

There is! And that works.

Why would there be two, one in Core Settings and one in Tree View preferences?

Must they both be off? Or does Tree View override Core Settings?

There is! And that works.

Why would there be two, one in Core Settings and one in Tree View preferences?

Must they both be off? Or does Tree View override Core Settings?

@lee-dohm

This comment has been minimized.

Show comment
Hide comment
@lee-dohm

lee-dohm Nov 17, 2014

Member

Hide Vcs Ignored Files is respected by more than just the Tree View package. It is also respected by the Fuzzy Finder and potentially any other package that offers similar functionality. This is why there are separate settings.

Member

lee-dohm commented Nov 17, 2014

Hide Vcs Ignored Files is respected by more than just the Tree View package. It is also respected by the Fuzzy Finder and potentially any other package that offers similar functionality. This is why there are separate settings.

@bobrocke

This comment has been minimized.

Show comment
Hide comment
@bobrocke

bobrocke Nov 17, 2014

if Hide Vcs Ignored Files affects other packages, why is the option in the Tree View package instead of Core Settings?

What does Exclude VCS Ignored Paths in Core Settings control?

if Hide Vcs Ignored Files affects other packages, why is the option in the Tree View package instead of Core Settings?

What does Exclude VCS Ignored Paths in Core Settings control?

@lee-dohm

This comment has been minimized.

Show comment
Hide comment
@lee-dohm

lee-dohm Nov 17, 2014

Member

Tree View is affected by the tree view setting. Fuzzy Finder et al are affected by the core setting. I didn't see that the screen shot referred to the Tree a view setting and got them reversed in my head.

On Nov 16, 2014, at 5:29 PM, Bob Rockefeller notifications@github.com wrote:

if Hide Vcs Ignored Files affects other packages, why is the option in the Tree View package instead of Core Settings?

What does Exclude VCS Ignored Paths in Core Settings control?


Reply to this email directly or view it on GitHub.

Member

lee-dohm commented Nov 17, 2014

Tree View is affected by the tree view setting. Fuzzy Finder et al are affected by the core setting. I didn't see that the screen shot referred to the Tree a view setting and got them reversed in my head.

On Nov 16, 2014, at 5:29 PM, Bob Rockefeller notifications@github.com wrote:

if Hide Vcs Ignored Files affects other packages, why is the option in the Tree View package instead of Core Settings?

What does Exclude VCS Ignored Paths in Core Settings control?


Reply to this email directly or view it on GitHub.

@bobrocke

This comment has been minimized.

Show comment
Hide comment
@bobrocke

bobrocke Nov 17, 2014

OK.

So why wouldn't Tree View respect the Core Setting and instead, need its own switch?

OK.

So why wouldn't Tree View respect the Core Setting and instead, need its own switch?

@lee-dohm

This comment has been minimized.

Show comment
Hide comment
@lee-dohm

lee-dohm Nov 17, 2014

Member

Because some people don't want to show ignored files in the Tree View but still want to open them with the Fuzzy Finder and vice versa.

Member

lee-dohm commented Nov 17, 2014

Because some people don't want to show ignored files in the Tree View but still want to open them with the Fuzzy Finder and vice versa.

@bobrocke

This comment has been minimized.

Show comment
Hide comment
@bobrocke

bobrocke Nov 17, 2014

I can see that.

Does it make sense then to have a Core Settings option at all? Would it be better to let each package set its options as it needs?

I can see that.

Does it make sense then to have a Core Settings option at all? Would it be better to let each package set its options as it needs?

@lee-dohm

This comment has been minimized.

Show comment
Hide comment
@lee-dohm

lee-dohm Nov 17, 2014

Member

What packages would those be other than Tree View?

Member

lee-dohm commented Nov 17, 2014

What packages would those be other than Tree View?

@bobrocke

This comment has been minimized.

Show comment
Hide comment
@bobrocke

bobrocke Nov 17, 2014

You mentioned Fuzzy Finder. I would imagine there could be more in the future, too.

You mentioned Fuzzy Finder. I would imagine there could be more in the future, too.

@lee-dohm

This comment has been minimized.

Show comment
Hide comment
@lee-dohm

lee-dohm Nov 18, 2014

Member

Yes, there could be. But all the ones that currently exist people want to change together other than Tree View. Until there is another that people want to change separately, the current system is the best solution.

On Nov 17, 2014, at 1:09 PM, Bob Rockefeller notifications@github.com wrote:

You mentioned Fuzzy Finder. I would imagine there could be more in the future, too.


Reply to this email directly or view it on GitHub.

Member

lee-dohm commented Nov 18, 2014

Yes, there could be. But all the ones that currently exist people want to change together other than Tree View. Until there is another that people want to change separately, the current system is the best solution.

On Nov 17, 2014, at 1:09 PM, Bob Rockefeller notifications@github.com wrote:

You mentioned Fuzzy Finder. I would imagine there could be more in the future, too.


Reply to this email directly or view it on GitHub.

@bobrocke

This comment has been minimized.

Show comment
Hide comment
@bobrocke

bobrocke Nov 18, 2014

Of course, this is ultimately a design decision.

My input would be that a global setting should be expected to affect everything. If the setting needs to be controlled by individual packages, there should be no global setting.

Or the package settings must clearly show how they override the global setting.

If I turn off the hiding of VCS ignored files in the Core Settings, it should be off for all packages. Or I can turn it on globally and let packages override that for their own features.

Of course, this is ultimately a design decision.

My input would be that a global setting should be expected to affect everything. If the setting needs to be controlled by individual packages, there should be no global setting.

Or the package settings must clearly show how they override the global setting.

If I turn off the hiding of VCS ignored files in the Core Settings, it should be off for all packages. Or I can turn it on globally and let packages override that for their own features.

@mark-hahn

This comment has been minimized.

Show comment
Hide comment
@mark-hahn

mark-hahn Nov 18, 2014

Contributor

If I turn off the hiding of VCS ignored files in the Core Settings, it
should be off for all packages. Or I can turn it on globally and let
packages override that for their own features.

Having it only as an AND is arbitrary. If you did that you should also
support OR.

It is customary to have a "use global" setting in the package instead.

On Tue, Nov 18, 2014 at 5:06 AM, Bob Rockefeller notifications@github.com
wrote:

Of course, this is ultimately a design decision.

My input would be that a global setting should be expected to affect
everything. If the setting needs to be controlled by individual packages,
there should be no global setting.

Or the package settings must clearly show how they override the global
setting.

If I turn off the hiding of VCS ignored files in the Core Settings, it
should be off for all packages. Or I can turn it on globally and let
packages override that for their own features.


Reply to this email directly or view it on GitHub
#4203 (comment).

Contributor

mark-hahn commented Nov 18, 2014

If I turn off the hiding of VCS ignored files in the Core Settings, it
should be off for all packages. Or I can turn it on globally and let
packages override that for their own features.

Having it only as an AND is arbitrary. If you did that you should also
support OR.

It is customary to have a "use global" setting in the package instead.

On Tue, Nov 18, 2014 at 5:06 AM, Bob Rockefeller notifications@github.com
wrote:

Of course, this is ultimately a design decision.

My input would be that a global setting should be expected to affect
everything. If the setting needs to be controlled by individual packages,
there should be no global setting.

Or the package settings must clearly show how they override the global
setting.

If I turn off the hiding of VCS ignored files in the Core Settings, it
should be off for all packages. Or I can turn it on globally and let
packages override that for their own features.


Reply to this email directly or view it on GitHub
#4203 (comment).

@bryanbraun

This comment has been minimized.

Show comment
Hide comment
@bryanbraun

bryanbraun May 13, 2015

Just wanted to chime in and say that I had this same problem and I found the two-settings piece pretty confusing. I just figured that the core "Hide VCS" button was broken (and I didn't know why the # of files being searched went way up). Took me about a week of irritation before I found this thread and got everything set correctly.

Maybe the UX could be improved by moving the Hide VCS setting down to the plugin layer for everything. fuzzy-finder, find-and-replace, and tree-view could all have their own, which makes for more granular configuration AND more clarity around the context of what is affected by the setting.

At least adding some description text to the core settings, similar to the text for the symlinks setting ("Used when searching and when opening files with the fuzzy finder"), would make it more clear what is affected by it.

Just wanted to chime in and say that I had this same problem and I found the two-settings piece pretty confusing. I just figured that the core "Hide VCS" button was broken (and I didn't know why the # of files being searched went way up). Took me about a week of irritation before I found this thread and got everything set correctly.

Maybe the UX could be improved by moving the Hide VCS setting down to the plugin layer for everything. fuzzy-finder, find-and-replace, and tree-view could all have their own, which makes for more granular configuration AND more clarity around the context of what is affected by the setting.

At least adding some description text to the core settings, similar to the text for the symlinks setting ("Used when searching and when opening files with the fuzzy finder"), would make it more clear what is affected by it.

@steve-ross

This comment has been minimized.

Show comment
Hide comment
@steve-ross

steve-ross May 20, 2015

Seems like there might still be an issue related to this. My search/replace and cmd-p search box is honoring the 'exclude vcs ignored paths' being off but, on the directory browser pane the directory is invisible.

Seems like there might still be an issue related to this. My search/replace and cmd-p search box is honoring the 'exclude vcs ignored paths' being off but, on the directory browser pane the directory is invisible.

@lee-dohm

This comment has been minimized.

Show comment
Hide comment
@lee-dohm

lee-dohm May 20, 2015

Member

As mentioned above, @steve-ross, the tree-view has its own setting for whether to display or not display VCS ignored files.

Member

lee-dohm commented May 20, 2015

As mentioned above, @steve-ross, the tree-view has its own setting for whether to display or not display VCS ignored files.

@joshontheweb

This comment has been minimized.

Show comment
Hide comment
@joshontheweb

joshontheweb Sep 10, 2015

I also found this very confusing. Luckily this thread showed up on a google search. The current behavior is not intuitive at all.

Edit: I think that in the very least, the setting in tree-view should default to off. That way at least you would have to know about the setting to end up in a state where your files are not showing up.

I also found this very confusing. Luckily this thread showed up on a google search. The current behavior is not intuitive at all.

Edit: I think that in the very least, the setting in tree-view should default to off. That way at least you would have to know about the setting to end up in a state where your files are not showing up.

@smiper

This comment has been minimized.

Show comment
Hide comment
@smiper

smiper Feb 24, 2016

I second @joshontheweb in this. The default ON of the tree-view setting is wrong in my opinion. This was way too confusing.

By the way I'm pretty sure the default of the Settings' "Exclude VCS Ignore Paths" was OFF but somehow it had turned on by itself?!

smiper commented Feb 24, 2016

I second @joshontheweb in this. The default ON of the tree-view setting is wrong in my opinion. This was way too confusing.

By the way I'm pretty sure the default of the Settings' "Exclude VCS Ignore Paths" was OFF but somehow it had turned on by itself?!

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot Apr 2, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

lock bot commented Apr 2, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked and limited conversation to collaborators Apr 2, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.