New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Quality Initiative #7995

Closed
benogle opened this Issue Jul 20, 2015 · 38 comments

Comments

Projects
None yet
@benogle
Contributor

benogle commented Jul 20, 2015

The Atom team will be focusing on quality for the next month or so. This effort is timeboxed: the plan is to finish around the beginning of Sept. This means we probably won't get everything done on this list during the allotted time window. After this time window, unfinished things will work into our normal issue handling routine.

What does this mean?

The goal of the quality initiative is to focus on fixing bugs and adding features that impact a lot of people, but are reasonably low effort. Why? There are a lot of low effort things affecting many people, and a lot of issues that slipped through the cracks while we were focused on the API and 1.0. We're just giving our selves some time to focus on them.

These will be small projects, ideally 1-2 days max. We will avoid rewrites or major refactoring.

The quality initiative will be our main focus, but we will still handle issues and review PRs—think of this effort as our 80% time.

What about X bug/feature?

After this quality initiative, we plan on shifting our 80% time to focus on things like performance, better support for international users, and some features we have in mind.

If you know of a bug or feature that is high-impact / low-effort, not in the list below, and does not fall under performance or internationalization, comment on this issue and we'll figure out if it fits in.

Core

Bug

  • Fix largest uncaught errors in bugsnag
  • Continue fixing uncaught errors from #7740
  • Fix erasing files when no disk space
  • Fix app auto-update issues
  • Fix app update and release notes issues
  • Investigate issues when changing branches
  • Cannot open files or folders on Mac OS X El Capitan beta #7811 (❤️ 🍎)
    • Likely fixed with upgrade to latest atom shell
  • Text editor interaction problems
    • Line up/down with multiple selections is broken #2470
    • Beeping when using ctrl-cmd-down
    • ctrl + up/down inserts  or  #6949
    • scrolling behavior while mouse-selecting whole lines of text is hard to control #6675 @nathansobo (PR #8123)
    • Selecting text with option + shift + arrow behaves differently to other Mac apps #6485
    • Undo of actions taken by package results in corrupted display of buffer #7516
    • Undo/redo doesn't change cursor position after multiple block edit #8178 - @maxbrunsfeld
    • Clicking and dragging up in gutter does not scroll #2696
    • Page Up and Page Down don't move correctly with the window. #8320
    • Multi line mouse select breaks in text editor when editor is small enough #8539 @nathansobo
    • Strange selection problem #8369
    • Overlay items flicker when near the edge of the window #8295
    • Shrink or scroll editor when panels at bottom open up #8068
    • cmd-l in multi-line selection doesn't select beginning of first line #3624
  • Keybinding Issues
  • Rendering issues
    • Showing line numbers disables sub-pixel AA on tabs, status-bar etc. #7904
    • Thin or small fonts rendered on Windows appear colorfully blurry. #7261
  • Window state
    • Reloading on an external monitor moves the window back to the primary monitor #6268
  • Open a file at a specific line #7342

Feature

Atom.io

Packages

Find and Replace

Settings View

Autocomplete

Fuzzy Finder

Bracket Matcher

  • Surrounding multiple words with ` characters is broken #6940

Modules

Pull requests to review

@ghost

This comment has been minimized.

ghost commented Jul 21, 2015

A minor feature that I've gotten used to from other editors is atom/find-and-replace#369 to be able to go back when I've accidentally pressed the return key too many times when searching for occurrences.

@190n

This comment has been minimized.

190n commented Jul 21, 2015

@mehcode

This comment has been minimized.

Contributor

mehcode commented Jul 21, 2015

Add a method to the API to switch the active project: #6984


Would allow for a sublime-style project switcher that I'm sure many of us were used to in sublime.

@ObviouslyGreen

This comment has been minimized.

ObviouslyGreen commented Jul 21, 2015

Dragging and dropping a file from the file system occasionally opens it as Chromium instead of Atom #4300

Having to restart atom after quickly dragging and dropping a file just to check something can be annoying at times, not sure if it affects everyone though since the issue report isn't super active.

@adamreisnz

This comment has been minimized.

adamreisnz commented Jul 22, 2015

This issue is possibly related to the fuzzy finder indexing issues: #7513

@Stargator

This comment has been minimized.

Stargator commented Jul 23, 2015

Maybe something concerning right clicking on a folder to create a file should automatically have the directory prepended without displaying as such to the user via the popup. As a new user when I saw that, I thought it was "wrong" and replaced it with just the name of the file as that has been the usually UI protocol for most, if not all, of other applications.

@adamreisnz

This comment has been minimized.

adamreisnz commented Jul 23, 2015

I actually like that feature. It allows me to change my mind if I decide to
create the file elsewhere, and makes it easy to copy paste the full path is
needed.
On Jul 24, 2015 2:46 AM, "Stargator" notifications@github.com wrote:

Maybe something concerning right clicking on a folder to create a file
should automatically have the directory prepended without displaying as
such to the user via the popup. As a new user when I saw that, I thought it
was "wrong" and replaced it with just the name of the file as that has been
the usually UI protocol for most, if not all, of other applications.


Reply to this email directly or view it on GitHub
#7995 (comment).

@gyf304

This comment has been minimized.

gyf304 commented Jul 24, 2015

I'd really appreciate fixing the 30 second freeze on windows platform. #7275

@Stargator

This comment has been minimized.

Stargator commented Jul 24, 2015

@adambuczynski Hmm, then I guess someone could look into making a plugin that toggles it on/off, if it isn't implemented in the main branch.

I always find once I decide where to put a file, I'm happy with it for a long while, barring any need to re-organize the project.

@gut4

This comment has been minimized.

gut4 commented Jul 24, 2015

What about "Non-native" Fullscreen on OSX? #967

@teresko

This comment has been minimized.

teresko commented Jul 26, 2015

The #2822 has been the only reason why I have not been able to migrate to Atom. It's nice to see, that it might change soon.

@faddah

This comment has been minimized.

faddah commented Jul 30, 2015

as an update, the issue in #7833 & #6612 about updating is still happening. this is on a 2009 iMac 27", intel core i7 2.8 GHz processor, 16 GB RAM, Mac OS X 10.10.4 Yosemite, and Atom Editor update going from v.1.0.2 to v.1.0.3. still happending, says it's downloaded the update and needs to restart, hit "restart," nothing happens. launch Atom Editor again, starts same process all over again, never updates. thought you'd want to know.

best,

— faddah
portland, oregon, u.s.a.

@tiemay

This comment has been minimized.

tiemay commented Aug 2, 2015

This cursor issue is pretty annoying, I don't know how much work would be involved to fix it though.

#3130, #3278, #3622

@jrsconfitto

This comment has been minimized.

Contributor

jrsconfitto commented Aug 4, 2015

i'd like to advocate for adding atom/find-and-replace#309 to the list, which i started, that i think may be related to the find and replace issues with searching when there's a dot in the name of the folder.

@blah238

This comment has been minimized.

blah238 commented Aug 5, 2015

Please add #6884 (Middle mouse button scrolling in the text editor) to the list, this is a pretty major usability issue for me.

@bronson

This comment has been minimized.

bronson commented Aug 6, 2015

Wondering about #2203 (git integration only works if .git is in the root dir). Worth including in this bugsmash?

@1j01

This comment has been minimized.

1j01 commented Aug 11, 2015

@ThibaudDauce

This comment has been minimized.

ThibaudDauce commented Aug 12, 2015

@tiemay +1 for cursor issues : #3130, #3278, #3622

@xeron

This comment has been minimized.

xeron commented Aug 13, 2015

What about grammar detection?

I have serious troubles using Atom with both Ruby and Rails projects because .rb files sometimes being opened with Ruby and sometimes with Ruby on Rails syntax.

Related report: atom/language-ruby-on-rails#34

@solarsailer

This comment has been minimized.

solarsailer commented Aug 13, 2015

I don't know the time it might take, but a recently-used/edited ordered fuzzy finder would be immensely useful.

I navigate almost solely through the fuzzy finder, and each time it shows me the exact same list in the same order even if I have never edited the first file of the list.

Sublime Text handles this pretty nicely.

The number of edits and open should be enough to rank a file higher than the others.

@bronson

This comment has been minimized.

bronson commented Aug 13, 2015

@solarsailer if cmd-b doesn't do what you want, you should open a new issue (search for existing ones first of course!). This is for tracking other issues.

@solarsailer

This comment has been minimized.

solarsailer commented Aug 14, 2015

cmd+b is only for already opened file. ;)

example

If I close my buffers, or if I quit/restart Atom, or if I come back later to edit the _entry.scss file, I have to go through all the results.

Atom should know that I edit _entry.scss quite often, then _entry.erb, then entry.rb. The fuzzy finder should evolve and take my habits into account.

@jensljungblad

This comment has been minimized.

jensljungblad commented Aug 18, 2015

Agreed about the grammar detection: atom/language-ruby-on-rails#34

@Ryex

This comment has been minimized.

Ryex commented Aug 27, 2015

I just want to point out that the item about line endings referring to #2822 has a check mark marking it as complete. it's not and should be unmarked so that it doesn't get overlooked.

thanks for this great work.

@maxbrunsfeld

This comment has been minimized.

Contributor

maxbrunsfeld commented Aug 27, 2015

@Ryex sorry for the confusion: we check these once we ship the code to master. The line endings feature is on Atom master, it just hasn't been released yet. Atom 1.0.8 is coming soon though!

Edit: Oh, also I see that I forgot to close that issue. Thanks for pointing that out.

@billyjanitsch

This comment has been minimized.

Contributor

billyjanitsch commented Sep 1, 2015

If you know of a bug or feature that is high-impact / low-effort, not in the list below, and does not fall under performance or internationalization, comment on this issue and we'll figure out if it fits in.

Would you consider taking a look at #3624? It's a frustrating, old bug that doesn't seem like it would be hard to fix.

@nathansobo

This comment has been minimized.

Contributor

nathansobo commented Sep 3, 2015

@billyjanitsch Thanks for the heads up. #3624 will be fixed on the next release.

@m1ga

This comment has been minimized.

m1ga commented Sep 3, 2015

An option "use restore session / ignore old session" would be also something to have a look at: #6605 (20 participants) since not all users want to start with an old session.
I don't know about the exact code parts but an if-function around the 'load old session' part shouldn't be a big feature (I hope so 😁 )

@solbjorn

This comment has been minimized.

solbjorn commented Sep 6, 2015

In addition to @m1ga's post, it would be very nice to see an option to restore saved session EVEN if launched WITH file arguments (like Sublime does), see #7186. It requires a few changes in src/browser/atom-application.coffee :suspect:

Also, in addition to atom/tabs#170: does not "Make preview-tabs really good" item mean also fixing atom/tabs#173? Really annoying bug with symlinks.

@adamreisnz

This comment has been minimized.

adamreisnz commented Sep 8, 2015

This issue for broken icon images seems like a good candidate for the quality initiative:

atom/settings-view#327

It's rather ugly with the broken images, and deleting the cached files doesn't help:

ss

@benogle

This comment has been minimized.

Contributor

benogle commented Sep 15, 2015

Closing this out. Most of the team's efforts are now dedicated toward performance. The rest of the unfinished items will be worked into our normal bug-fixing / enhancement-adding process.

@benogle benogle closed this Sep 15, 2015

@nathansobo

This comment has been minimized.

Contributor

nathansobo commented Sep 15, 2015

We'll do another focused pass like this once some more performance improvements land.

@adamreisnz

This comment has been minimized.

adamreisnz commented Sep 15, 2015

That's a pity, there's a lot of issues lingering in here still that would benefit from one last push :)

@benogle

This comment has been minimized.

Contributor

benogle commented Sep 15, 2015

That's a pity, there's a lot of issues lingering in here still that would benefit from one last push :)

Agreed. But we only have so many people!

@adamreisnz

This comment has been minimized.

adamreisnz commented Sep 15, 2015

Clearly need more :D

@benogle

This comment has been minimized.

Contributor

benogle commented Sep 15, 2015

Clearly need more :D

Working on it...

@jesseleite

This comment has been minimized.

jesseleite commented Sep 18, 2015

Thank you all for your work on Atom! 💖

@jeancroy

This comment has been minimized.

Contributor

jeancroy commented Sep 23, 2015

@benogle

I'd like to propose grandfathering atom/fuzzaldrin#22 from The Quality Initiative to the Performance one.

After a few performance push it's now 2x faster than classic fuzzaldrin on official benchmark query. It's also 2X faster in a variety of condition and I'm tempted to say on average.

In addition to being faster it could close about 6 open issues including 2 that act as catch-all. It play a central role in autocomplete, fuzzy-finder and command palette, thus in the overall atom experience.

To help review process I've included a documentation for the PR, including a section on benchmark and addressed issue. (near the end)

It's a large PR, by this time a rewrite, it may take a few day to review it. However it is more accurate, faster, backward compatible, and by now there's probably the equivalent of a month of full time work invested in it.

Even outside an official review process it would be great to have some feedback. The impression of shooting in the dark is a bit discouraging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment