Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Introduce scheme to `npm dedupe` npm dependencies of Atom packages #8217
Currently, the organization of the
Specifically, in the case of Nuclide, we have our
I suspect that the only thing I can do right now without any changes to Atom is have
where npm packages common to multiple Nuclide Atom packages would be written to
Once everything was in place,
While I'm rubber ducking, I would probably add another directory of indirection so that the directory structure would be parameterized by version number:
This is really important for Nuclide, so I'm willing to hack this into
This is definitely true, especially on Windows, calling
We could de-dupe modules common to all packages by storing them in
This really makes me wonder about doing something that isn't based on the file system in terms of reusing required modules across the entire application. The problem with such a change is it breaks the simple semantics of Node's
Hmm, if we had:
as a symlink to (that was created via
would it look in
The thing I dislike about that is that while in the process of going from v0.0.26 to v0.0.27, the versions of our
Why don't you check for an existing npm package that matches during your install? If the version check passes, use the existing module, if not run apm install.
I've also run into similar issues where I need to use different versions of some packages and the same on others. I created a symlink between folders so the program didn't know it was checking another folder.
Not trying to beat a known horse (src install should work, right), but I'm running into install time far longer than 6 mins due to capped I/O when trying nuclide-installer. Although it hasn't fully installed yet, its happening on Windows 10 via Atom GUI. I started the install at aprx ~10:20am, and now it's a little over halfway done at ~11:40am. Considering its mentioned that there are only 17 packages within that meta plugin, this seems wonked.
Albeit it non SSD, this is a 64bit 8gb 3k machine, it's not like it's too underpowered to run an editor. I concur it's all the files in nuclide-installer meta, although perhaps Evented I/O running 32bit instead of 64bit could compound that effect.
EDIT: after installing, Atom crashes out totally spikes I/O way higher peaking 15 MB/s