New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having both "Exclude VCS Ignored Paths" and "Hide VCS Ignored Paths" settings is confusing #8276

Closed
mehcode opened this Issue Aug 7, 2015 · 7 comments

Comments

Projects
None yet
5 participants
@mehcode
Contributor

mehcode commented Aug 7, 2015

image

The Exclude VCS Ignored Paths setting under Core Settings commonly gets confused with the similar setting under the Tree View package, Hide VCS Ignored Paths. I believe the first is for excluding files from search and the latter is for the tree view itself.

For an idealized UI I'd vote for removing both settings and adding a new one that is a Select box where we can select to exclude (from search and tree view), exclude from search only, and show. It doesn't make sense (to me) to allow not showing in the tree view but showing up in search.

We could also just add some explanation text to both settings if the above is too radical a change.

// ref #8270

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Aug 7, 2015

Member

Another option would be to rename the settings to Exclude VCS Ignored Paths From Search and Hide VCS Ignored Paths from Tree View, respectively. Of course, if either of the settings has a broader impact, then this won't work :P.

Member

50Wliu commented Aug 7, 2015

Another option would be to rename the settings to Exclude VCS Ignored Paths From Search and Hide VCS Ignored Paths from Tree View, respectively. Of course, if either of the settings has a broader impact, then this won't work :P.

@50Wliu 50Wliu added the enhancement label Aug 7, 2015

@surdu

This comment has been minimized.

Show comment
Hide comment
@surdu

surdu Sep 2, 2015

I'm here because I wanted to file a bug that Exclude VCS Ignored Paths is not honoured in TreeView, so yeah, it's confusing 😄

surdu commented Sep 2, 2015

I'm here because I wanted to file a bug that Exclude VCS Ignored Paths is not honoured in TreeView, so yeah, it's confusing 😄

@tomByrer

This comment has been minimized.

Show comment
Hide comment
@tomByrer

tomByrer Jan 21, 2016

The check box would be more clear if it was:

  • "Hide .gitignore files"

tomByrer commented Jan 21, 2016

The check box would be more clear if it was:

  • "Hide .gitignore files"
@surdu

This comment has been minimized.

Show comment
Hide comment
@surdu

surdu Jan 22, 2016

@tomByrer In your variant, I would believe that by checking the checkbox it will hide the .gitignore files themselves from the tree view, which is not the intended function.

surdu commented Jan 22, 2016

@tomByrer In your variant, I would believe that by checking the checkbox it will hide the .gitignore files themselves from the tree view, which is not the intended function.

@hypnoboutique

This comment has been minimized.

Show comment
Hide comment
@hypnoboutique

hypnoboutique Jan 20, 2017

I second this. Having both settings is confusing. Especially as you have to dig a bit to get to the tree-view settings.

The fact that I'm still unclear on the difference make me think that this is a UX issue (or I'm an idiot, which is also feasible).

p.s. For future sailors: pressing i in the tree view will toggle your ignored files. You might find this useful in diagnosing why they disappeared in the first place.

hypnoboutique commented Jan 20, 2017

I second this. Having both settings is confusing. Especially as you have to dig a bit to get to the tree-view settings.

The fact that I'm still unclear on the difference make me think that this is a UX issue (or I'm an idiot, which is also feasible).

p.s. For future sailors: pressing i in the tree view will toggle your ignored files. You might find this useful in diagnosing why they disappeared in the first place.

@stale

This comment has been minimized.

Show comment
Hide comment
@stale

stale bot Jan 20, 2018

Thanks for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. Because the Atom team treats their issues as their backlog, stale issues are closed. If you would like this issue to remain open:

  1. Verify that you can still reproduce the issue in the latest version of Atom
  2. Comment that the issue is still reproducible and include:
    • What version of Atom you reproduced the issue on
    • What OS and version you reproduced the issue on
    • What steps you followed to reproduce the issue

Issues that are labeled as triaged will not be automatically marked as stale.

stale bot commented Jan 20, 2018

Thanks for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. Because the Atom team treats their issues as their backlog, stale issues are closed. If you would like this issue to remain open:

  1. Verify that you can still reproduce the issue in the latest version of Atom
  2. Comment that the issue is still reproducible and include:
    • What version of Atom you reproduced the issue on
    • What OS and version you reproduced the issue on
    • What steps you followed to reproduce the issue

Issues that are labeled as triaged will not be automatically marked as stale.

@stale stale bot added the stale label Jan 20, 2018

@stale stale bot closed this Feb 3, 2018

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot Aug 2, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

lock bot commented Aug 2, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.