Make it easier to define user key bindings #12760

Merged
merged 3 commits into from Sep 22, 2016

Projects

None yet

3 participants

@maxbrunsfeld
Contributor
  1. User key bindings now take precedence over package key bindings regardless of their selector specificity.
  2. We now throw errors if key binding files contain duplicate keys. This was an easy error to make because it's easy to think of these CSON files as working like style sheets, rather than JSON objects.

Closes atom/atom-keymap#110

๐Ÿ w/ @nathansobo

maxbrunsfeld added some commits Sep 22, 2016
@maxbrunsfeld @nathansobo maxbrunsfeld โฌ†๏ธ atom-keymap for new priority semantics
Signed-off-by: Nathan Sobo <nathan@github.com>
59189dc
@maxbrunsfeld @nathansobo maxbrunsfeld Disallow duplicate keys when loading package keymaps
Signed-off-by: Nathan Sobo <nathan@github.com>
db781dd
@nathansobo nathansobo referenced this pull request in atom/atom-keymap Sep 22, 2016
Closed

Overriding keybindings is unintuitive and difficult #110

@maxbrunsfeld maxbrunsfeld โฌ†๏ธ season
fff8ca1
@nathansobo nathansobo merged commit 6535c64 into master Sep 22, 2016

8 checks passed

atom Build #4212775 succeeded in 1s
Details
atom-linux Build #4212776 succeeded in 1s
Details
atom-rpm Build #4212777 succeeded in 2s
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@nathansobo nathansobo deleted the mb-ns-better-user-bindings branch Sep 22, 2016
@Ben3eeE
Member
Ben3eeE commented Sep 23, 2016

Sounds like it can apply to atom/settings-view#510 in some way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment