Redirect apm scripts to use the actual apm ones #12929

Merged
merged 1 commit into from Dec 13, 2016

Projects

None yet

2 participants

@50Wliu
Member
50Wliu commented Oct 10, 2016

The Windows scripts in atom/apm have been kept considerably more up-to-date than the ones in atom/atom. This PR updates the apm scripts in atom/atom to call the ones in atom/apm and fixes the issue where node-gyp can't be found while apm installing.

There are two alternative solutions:

  1. Remove the scripts from this repository and symlink the atom/apm scripts, as is done for macOS and Linux
  2. Remove the scripts from this repository and update PATH to include the scripts in atom/apm.
@50Wliu 50Wliu Redirect apm scripts to use the actual apm ones
1efda55
@50Wliu 50Wliu added the needs-review label Oct 25, 2016
@damieng damieng merged commit 59dfb9e into master Dec 13, 2016

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@damieng damieng deleted the wl-use-scripts-from-apm branch Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment