Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #11848 Moving line up without line ending #12946

Merged

Conversation

Projects
None yet
5 participants
@jamsinclair
Copy link

commented Oct 11, 2016

Bug

Fixes the bug described in issue #11848

move-line-up-bug

Fix

From what I explored it looks like a previous dev has tried to fix this bug. Although because rows are 0 indexed, to select the penultimate row for the range it requires using -2.

I wonder whether it's worth rewriting the line:

lines += '\n' unless lines[lines.length - 1] is '\n'

I've attempted to add a valid test. Suggestions to improve or better represent the test welcome 馃樃

move-line-up-fix

@borishere

This comment has been minimized.

Copy link

commented May 13, 2017

Just why this is not yet merged??

@lee-dohm

This comment has been minimized.

Copy link
Member

commented May 13, 2017

Thanks for this!

@lee-dohm lee-dohm merged commit 1559c8a into atom:master May 13, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.