Update Octicons #13138

Merged
merged 4 commits into from Nov 4, 2016

Conversation

Projects
None yet
2 participants
@simurai
Member

simurai commented Nov 3, 2016

This updates the Octicons to 4.4.0 (almost newest). Some of the old icons from 2.1.2 that got removed in the meantime will still be available in Atom, so no packages should have missing icons.

Before After
screen shot 2016-11-03 at 7 54 01 pm screen shot 2016-11-03 at 7 54 22 pm

Here the 20 new icons that will be available:

screen shot 2016-11-03 at 7 22 20 pm

Concerns

All icons should be fine except that the GitHub wordmark is much smaller. We can update the font size in places where we use that icon, like on the About page. The "Gist" icon is also quite small, but since it's a new one, it hasn't been used anywhere.

Remaining tasks:

Closes #8314
Will be in Atom 1.13

simurai added some commits Nov 2, 2016

Use Octicons 4.4
but still keep the old 2.1.2 version for backwards compatibility
Revert chaning mixin name
git-diff seems to use `.octicon-font()`
Replace Octicons 4.4.0 with a normalized version
So that text-align center still works
Add new icons
- beaker
- bell
- bold
- desktop-download
- ellipses
- file
- grabber
- italic
- logo-gist
- plus-small
- reply
- shield
- smiley
- tasklist
- text-size
- thumbsdown
- thumbsup
- unverified
- verified
- watch

@simurai simurai referenced this pull request Nov 3, 2016

Closed

Update to Octicons 3.0 #8314

@simurai

This comment has been minimized.

Show comment
Hide comment
@simurai

simurai Nov 3, 2016

Member

Btw. this will probably be the last update as "font icons" because the newer Octicons 5.0 only support SVG.

And we should also move to SVG icons.. @joefitzgerald already got an etch version here: https://github.com/joefitzgerald/etch-octicon

Member

simurai commented Nov 3, 2016

Btw. this will probably be the last update as "font icons" because the newer Octicons 5.0 only support SVG.

And we should also move to SVG icons.. @joefitzgerald already got an etch version here: https://github.com/joefitzgerald/etch-octicon

@simurai simurai merged commit 1f66688 into master Nov 4, 2016

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@simurai simurai deleted the sm-octicons branch Nov 4, 2016

@Alhadis

This comment has been minimized.

Show comment
Hide comment
@Alhadis

Alhadis Nov 10, 2016

Needs more padlocks:

kek

Don't think we can ship with only four.

Alhadis commented Nov 10, 2016

Needs more padlocks:

kek

Don't think we can ship with only four.

Alhadis added a commit to file-icons/source that referenced this pull request Nov 12, 2016

Update Rollup, copy Octicons, and add SilverStripe
* Octicons: This commit adds copies of certain Octicons visibly affected
  by Atom 1.13's upgrade to Octicons 4.4.0 (see atom/atom#13138):

    - Config/settings
    - Dashboard (used by Slim templates)
    - Image (default icon for media formats)
    - Tag (used for tagfiles)
    - Terminal (used for shell-scripts/misc executables)
    - Video (used for generic video formats)

  Codepoints match those used by Octicons, for the sake of symmetry.

* SilverStripe: Codepoint chosen to match atom-silverstripe's icon-font.
  See gorriecoe/atom-silverstripe@2505984

peymanslh added a commit to peymanslh/welcome that referenced this pull request Sep 3, 2017

@peymanslh peymanslh referenced this pull request in atom/welcome Sep 3, 2017

Merged

Fix GitHub icon in 'Telemetry Consent' page #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment