Make core and render tests pass on Windows #13305

Merged
merged 21 commits into from Nov 30, 2016

Projects

None yet

1 participant

@damieng
Member
damieng commented Nov 22, 2016

Fixes #11543 and makes Windows a safer place to do dev work happy in the knowledge you can actually run the tests and (probably) didn't break anything.

  • Many tests were fixed (normally paths)
  • A few tests were bypassed (screen co-ordinates, portable, smoke)
  • Some functionality was fixed (internal theme id mangling)
  • Chromedriver is now downloaded and used on Windows & Linux
  • Windows now runs main and ui tests

Life after this

c:\atom> script\test
Executing core render process tests

...................................................------......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

Finished in 108.754 seconds
2009 tests, 7657 assertions, 0 failures, 6 skipped


Executing core main process tests

  AtomApplication
    launch
      √ can open to a specific line number of a file (1548ms)
      √ can open to a specific line and column of a file (1533ms)
      √ removes all trailing whitespace and colons from the specified path (1545ms)
      √ positions new windows at an offset distance from the previous window (2337ms)
      √ reuses existing windows when opening paths, but not directories (2752ms)
      √ adds folders to existing windows when the --add option is used (1752ms)
      √ persists window state based on the project directories (2492ms)
      √ shows all directories in the tree view when multiple directory paths are passed to Atom (2180ms)
      √ reuses windows with no project paths to open directories (1646ms)
      √ opens a new window with a single untitled buffer when launched with no path, even if windows already exist (3022ms)
      √ does not open an empty editor when opened with no path if the core.openEmptyEditorOnStart config setting is false (2137ms)
      √ opens an empty text editor and loads its parent directory in the tree-view when launched with a new file path (1587ms)
      √ adds a remote directory to the project when launched with a remote directory (2942ms)
      √ reopens any previously opened windows when launched with no path (3612ms)
      √ does not reopen any previously opened windows when launched with no path and `core.restorePreviousWindowsOnStart` is false (3997ms)
      when closing the last window
        √ quits the application (1607ms)
    before quitting
      √ waits until all the windows have saved their state and then quits (2757ms)

  FileRecoveryService
    √ doesn't create a recovery file when the file that's being saved doesn't exist yet
    when no crash happens during a save
      √ creates a recovery file and deletes it after saving (1023ms)
      √ creates only one recovery file when many windows attempt to save the same file, deleting it when the last one finishes saving it
    when a crash happens during a save
      √ restores the created recovery file and deletes it
      √ restores the created recovery file when many windows attempt to save the same file and one of them crashes
      √ emits a warning when a file can't be recovered


  23 passing (43s)

image

@damieng damieng added the windows label Nov 22, 2016
damieng added some commits Nov 22, 2016
@damieng damieng Support node's option.shell entirely, buffered-process tests now pass…
… on Windows
20b29fb
@damieng damieng Environment patching tests do not work on Win32 48b16a4
@damieng damieng Allow GitRepository tests to pass on Win32 2014b2a
@damieng damieng Project and Window-Event-Handler spec pass on Win32 711d839
@damieng damieng Remove dangerous win32 portable test a267286
@damieng damieng Lines-yardstick has different measurements on win32 bd9ed68
@damieng damieng Text editor measures diff in one test on win32 e89c5ef
@damieng damieng Fix MenuManager spec that forget to set darin to test macOS behavior eac4f04
@damieng damieng Prevent text from leaving fixture modified 9e5353a
@damieng damieng Skip autoupdater tests on Win32, we don't use electron autoUpdate there cf0bae0
@damieng damieng Fix id/source-path for themes on Win32 bd2f6d6
@damieng damieng Remove use of deleted stringtoid function c0bb35d
@damieng damieng Fix package-transpilation-registry tests on Win32 701b08c
@damieng damieng 👕 7a5b5ef
@damieng damieng Add chromedriver for Windows & Linux 643038e
@damieng damieng Integration tests now pass on Win32 4c4fa2b
@damieng damieng Disable portable tests, mess with env 76d058c
@damieng damieng Smoke test only passes on macOS 440e708
@damieng damieng Tidy up which tests run on which OS a18adfe
@damieng damieng Switch node to build with to 6.8.0
9595911
@damieng damieng Do not run core render process tests on win32/ia32. They crash Atom i…
…n TextEditor specs - possible resource limitation.
6aa46cf
@damieng damieng merged commit b4c67cb into master Nov 30, 2016

4 of 5 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@damieng damieng deleted the dg-windows-tests-pass branch Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment