Upgrade to Electron 1.3.13 #13353

Merged
merged 2 commits into from Dec 7, 2016

Projects

None yet

3 participants

@kevinsawicki
Member
kevinsawicki commented Nov 28, 2016 edited

Upgrade to Electron 1.3.13 which includes some important bug fixes and an upstream Chrome patch that (hopefully) addresses the Linux keybinding issues on certain layouts when pressing Ctrl.

/cc @as-cii @Ben3eeE the version of Electron with the keybinding fix (1.3.13) is now on this branch if you want to try it out 🐧

@kevinsawicki kevinsawicki changed the title from :arrow_up: electron@1.3.12 to Upgrade to Electron 1.3.12 Nov 28, 2016
@as-cii as-cii referenced this pull request Dec 5, 2016
Closed

Reported potential regressions in v1.12 release #13198

11 of 12 tasks complete
kevinsawicki added some commits Nov 28, 2016
@kevinsawicki kevinsawicki ⬆️ electron@1.3.12 027f835
@kevinsawicki kevinsawicki ⬆️ electron@1.3.13
fab21bc
@kevinsawicki kevinsawicki changed the title from Upgrade to Electron 1.3.12 to Upgrade to Electron 1.3.13 Dec 6, 2016
@Ben3eeE
Member
Ben3eeE commented Dec 7, 2016

Awesome thanks. @as-cii I can check this out tonight or tomorrow. Let me know if you want to go ahead and merge before I have a chance to test this PR.

@as-cii
Member
as-cii commented Dec 7, 2016

@Ben3eeE: I'll be optimistic and 🚢 this, but it would be awesome if you can test it out when you get the chance. ❤️

A huge shoutout goes to @kevinsawicki for addressing this so quickly! Thank you so much! 💯

@as-cii as-cii merged commit 37d9aa5 into master Dec 7, 2016

4 of 5 checks passed

ci/circleci Your tests failed on CircleCI
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@as-cii as-cii deleted the ks-electron-1-3-12 branch Dec 7, 2016
@Ben3eeE
Member
Ben3eeE commented Dec 7, 2016

Gave this a quick round of testing and it seems that the issue has been fixed. We need to change atom to use the event as it still resolves incorrectly. I will test again after those changes are in to better verify without having to resort to reading the events in the dev tools console.

Thanks so much for this @kevinsawicki awesome work 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment