Replace `libXScrnSaver` with `libXss.so.1` in RPM package spec #13386

Merged
merged 1 commit into from Dec 7, 2016

Projects

None yet

4 participants

@as-cii
Member
as-cii commented Dec 5, 2016 edited

Closes #13354

This pull request fixes a regression introduced in #13289 that prevented Atom from installing on openSUSE because of a missing dependency. Replacing libXScrnSaver with libXss.so.1 seems to address the problem, making Atom install as expected on Fedora as well as openSUSE.

@cobexer @Adobe-Android @dominuskernel: can you try building this branch and test that it works as expected on your machine? Thanks!

@as-cii as-cii Replace `libXScrnSaver` with `libXss.so.1`
4c5d93a
@as-cii as-cii referenced this pull request Dec 5, 2016
Closed

Reported potential regressions in v1.12 release #13198

11 of 12 tasks complete
@as-cii as-cii merged commit e228eb8 into master Dec 7, 2016

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@as-cii as-cii deleted the as-cross-platform-lib-xss branch Dec 7, 2016
@Adobe-Android

Thanks @as-cii for working on this. I will test the beta when released for sure!

@philwyett-hemi
Contributor
philwyett-hemi commented Dec 9, 2016 edited

This seems to cause issue when doing a 'yum localinstall' (update from 1.12.6) on CentOS 7. It is trying to pull in 686 packages when it should not.

`[philwyett@hemi-yoda Downloads]$ sudo yum localinstall atom.x86_64.rpm
[sudo] password for philwyett:
Loaded plugins: changelog, fastestmirror, langpacks
Examining atom.x86_64.rpm: atom-1.12.7-0.1.x86_64
Marking atom.x86_64.rpm as an update to atom-1.12.6-0.1.x86_64
Resolving Dependencies
--> Running transaction check
---> Package atom.x86_64 0:1.12.6-0.1 will be updated
---> Package atom.x86_64 0:1.12.7-0.1 will be an update
--> Processing Dependency: libXss.so.1 for package: atom-1.12.7-0.1.x86_64
adobe-linux-x86_64 | 951 B 00:00
base | 3.6 kB 00:00
cr | 3.4 kB 00:00
epel/x86_64/metalink | 18 kB 00:00
epel | 4.3 kB 00:00
extras | 3.4 kB 00:00
hemi | 3.0 kB 00:00
hemi-epel | 3.0 kB 00:00
updates | 3.4 kB 00:00
(1/10): base/7/x86_64/group_gz | 155 kB 00:00
(2/10): epel/x86_64/group_gz | 170 kB 00:01
(3/10): extras/7/x86_64/primary_db | 166 kB 00:01
(4/10): hemi/primary_db | 11 kB 00:00
(5/10): hemi-epel/primary_db | 3.7 kB 00:00
(6/10): epel/x86_64/updateinfo | 679 kB 00:04
(7/10): epel/x86_64/primary_db | 4.4 MB 00:10
(8/10): cr/7/x86_64/primary_db | 3.7 MB 00:15
(9/10): base/7/x86_64/primary_db | 5.3 MB 00:15
(10/10): updates/7/x86_64/primary_db | 9.1 MB 00:16
adobe-linux-x86_64/primary | 1.2 kB 00:00
Determining fastest mirrors
Including mirror: mirror.bytemark.co.uk
Including mirror: anorien.csc.warwick.ac.uk
Including mirror: mirrors.ukfast.co.uk
Including mirror: epel.check-update.co.uk

  • epel: mirror.bytemark.co.uk
    Including mirror: mirrors.melbourne.co.uk
    Including mirror: centos.mirroring.pulsant.co.uk
    Including mirror: mirror.sov.uk.goscomb.net
    Including mirror: repo.uk.bigstepcloud.com
    Including mirror: centos.mirrors.nublue.co.uk
    Including mirror: mirror.mhd.uk.as44574.net
    Including mirror: mirror.sax.uk.as61049.net
    Including mirror: mirror.ox.ac.uk
  • extras: mirrors.melbourne.co.uk
    adobe-linux-x86_64 2/2
    --> Running transaction check
    ---> Package libXScrnSaver.i686 0:1.2.2-6.1.el7 will be installed
    --> Processing Dependency: libc.so.6(GLIBC_2.4) for package: libXScrnSaver-1.2.2-6.1.el7.i686
    --> Processing Dependency: libXext.so.6 for package: libXScrnSaver-1.2.2-6.1.el7.i686
    --> Processing Dependency: libX11.so.6 for package: libXScrnSaver-1.2.2-6.1.el7.i686
    --> Running transaction check
    ---> Package glibc.i686 0:2.17-157.el7_3.1 will be installed
    --> Processing Dependency: libfreebl3.so(NSSRAWHASH_3.12.3) for package: glibc-2.17-157.el7_3.1.i686
    --> Processing Dependency: libfreebl3.so for package: glibc-2.17-157.el7_3.1.i686
    ---> Package libX11.i686 0:1.6.3-3.el7 will be installed
    --> Processing Dependency: libxcb.so.1 for package: libX11-1.6.3-3.el7.i686
    ---> Package libXext.i686 0:1.3.3-3.el7 will be installed
    --> Running transaction check
    ---> Package libxcb.i686 0:1.11-4.el7 will be installed
    --> Processing Dependency: libXau.so.6 for package: libxcb-1.11-4.el7.i686
    ---> Package nss-softokn-freebl.i686 0:3.16.2.3-14.4.el7 will be installed
    --> Running transaction check
    ---> Package libXau.i686 0:1.0.8-2.1.el7 will be installed
    --> Finished Dependency Resolution

Dependencies Resolved

================================================================================
Package Arch Version Repository Size

Updating:
atom x86_64 1.12.7-0.1 /atom.x86_64 241 M
Installing for dependencies:
glibc i686 2.17-157.el7_3.1 cr 4.2 M
libX11 i686 1.6.3-3.el7 cr 610 k
libXScrnSaver i686 1.2.2-6.1.el7 base 24 k
libXau i686 1.0.8-2.1.el7 base 29 k
libXext i686 1.3.3-3.el7 base 39 k
libxcb i686 1.11-4.el7 base 202 k
nss-softokn-freebl i686 3.16.2.3-14.4.el7 cr 188 k

Transaction Summary

Install ( 7 Dependent packages)
Upgrade 1 Package

Total size: 247 M
Total download size: 5.3 M
Is this ok [y/d/N]:`

@Fisiu
Fisiu commented Jan 10, 2017

No, this still pulls 32bit dependencies on x64 system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment