Suppress TextEditorScrollView scrolled when it shouldn't have warning #13411

Merged
merged 1 commit into from Dec 8, 2016

Projects

None yet

2 participants

@joefitzgerald
Member

Per @nathansobo, we’re not sure whether it’s even helpful to know that the text editor has scrolled in this way. It seems to occur often, and I notice it particularly when testing autocomplete-plus providers.

Before:

screen shot 2016-12-09 at 10 09 20 am

After:

screen shot 2016-12-09 at 10 10 22 am

@joefitzgerald joefitzgerald Remove console warning
- Per @nathansobo, we’re not sure whether it’s even helpful to know this
9be8373
@nathansobo nathansobo merged commit 89e3891 into master Dec 8, 2016

0 of 5 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@nathansobo nathansobo deleted the jf-suppress-editor-warning branch Dec 8, 2016
@nathansobo
Contributor

👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment