Multiple fixes for RPM and in docs RPM distros. #13421

Merged
merged 3 commits into from Dec 12, 2016

Projects

None yet

7 participants

@philwyett-hemi
Contributor
philwyett-hemi commented Dec 10, 2016 edited
  • Correct requires for libXss across Fedora/RedHat (and derivatives) and SUSE.
  • Split instructions for Fedora and RHEL etc. i.e. yum and dnf.
  • Never use --assumeyes or -y installing packages. atom 1.12.7 shows if
    this had been done by end users it would have caused them great issue.
  • Fedora 22 is End Of Life (EOL), so no instructions needed.
philwyett-hemi added some commits Dec 10, 2016
@philwyett-hemi philwyett-hemi Commit...
* Correct requires for libXss across Fedora/RedHat (and derivatives) and SUSE.
af4da94
@philwyett-hemi philwyett-hemi Commit...
* Split instructions for Fedora and RHEL etc. i.e. yum and dnf.
* Never use --assumeyes or -y installing packages. atom 1.12.7 shows if
  this had been done by end users it would have caused them great issue.
4952659
@philwyett-hemi philwyett-hemi Commit...
* Fedora 22 is End Of Life (EOL), so no instructions needed.
76f08a8
@philwyett-hemi philwyett-hemi changed the title from Commit... to Multiple fixes for RPM and in docs RPM distros. Dec 10, 2016
@as-cii
Member
as-cii commented Dec 12, 2016

Looks great, thanks @philwyett-hemi!

@as-cii as-cii merged commit bc0666d into atom:master Dec 12, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@as-cii as-cii referenced this pull request Dec 12, 2016
Closed

Reported potential regressions in v1.12 release #13198

11 of 12 tasks complete
@mikequentel

On CentOS 7.2, had to install dependencies then run the rpm -ivh:

  • sudo yum install lsb
  • sudo yum install libXScrnSaver.i686
  • sudo rpm -ivh atom.x86_64.rpm
@ungb
ungb commented Jan 3, 2017 edited

@philwyett-hemi @as-cii Testing this change on centos, I'm seeing the following error:

This change went out on stable and beta. @iolsen, We should probably roll this change back as 1.12.7 works with work around. 1.12.8 won't install due to the error found here.
screenshot:
image

[bryant@localhost Downloads]$ sudo yum localinstall atom.x86_64.rpm
[sudo] password for bryant:
Loaded plugins: fastestmirror, langpacks
Examining atom.x86_64.rpm: atom-1.12.8-0.1.x86_64
Marking atom.x86_64.rpm to be installed
Resolving Dependencies
--> Running transaction check
---> Package atom.x86_64 0:1.12.8-0.1 will be installed
--> Processing Dependency: lsb-core-noarch for package: atom-1.12.8-0.1.x86_64
Loading mirror speeds from cached hostfile
* base: mirror.keystealth.org
* extras: centos.sonn.com
* updates: centos.mirror.lstn.net
--> Processing Dependency: libXss1 for package: atom-1.12.8-0.1.x86_64
--> Running transaction check
---> Package atom.x86_64 0:1.12.8-0.1 will be installed
--> Processing Dependency: libXss1 for package: atom-1.12.8-0.1.x86_64
---> Package redhat-lsb-core.x86_64 0:4.1-27.el7.centos.1 will be installed
--> Processing Dependency: redhat-lsb-submod-security(x86-64) = 4.1-27.el7.centos.1 for package: redhat-lsb-core-4.1-27.el7.centos.1.x86_64
--> Processing Dependency: spax for package: redhat-lsb-core-4.1-27.el7.centos.1.x86_64
--> Processing Dependency: /usr/bin/m4 for package: redhat-lsb-core-4.1-27.el7.centos.1.x86_64
--> Running transaction check
---> Package atom.x86_64 0:1.12.8-0.1 will be installed
--> Processing Dependency: libXss1 for package: atom-1.12.8-0.1.x86_64
---> Package m4.x86_64 0:1.4.16-10.el7 will be installed
---> Package redhat-lsb-submod-security.x86_64 0:4.1-27.el7.centos.1 will be installed
---> Package spax.x86_64 0:1.5.2-13.el7 will be installed
--> Finished Dependency Resolution
Error: Package: atom-1.12.8-0.1.x86_64 (/atom.x86_64)
Requires: libXss1
You could try using --skip-broken to work around the problem
** Found 3 pre-existing rpmdb problem(s), 'yum check' output follows:
ipa-client-4.4.0-14.el7.centos.1.1.x86_64 has installed conflicts freeipa-client: ipa-client-4.4.0-14.el7.centos.1.1.x86_64
ipa-client-common-4.4.0-14.el7.centos.1.1.noarch has installed conflicts freeipa-client-common: ipa-client-common-4.4.0-14.el7.centos.1.1.noarch
ipa-common-4.4.0-14.el7.centos.1.1.noarch has installed conflicts freeipa-common: ipa-common-4.4.0-14.el7.centos.1.1.noarch

1.12.7 works after you run sudo yum install libXScrnSaver on centos

Tested on Centos 7.3.611

@lucascosti

+1 to @ungb , I can't install 1.12.8 on Fedora 24.

Error: nothing provides libXss1 needed by atom-1.12.8-0.1.x86_64

libXScrnSaver is already installed on my system:

dnf list installed libXScrnSaver
Installed Packages
libXScrnSaver.i686                                   1.2.2-10.fc24
libXScrnSaver.x86_64                                 1.2.2-10.fc24
@trypag
trypag commented Jan 4, 2017

Same here, fedora 25, can't install 1.12.8. did this :

sudo dnf install libgnome-keyring-devel rpmdevtools libX11-devel libxkbfile-devel libXScrnSaver

but still

Error: nothing provides libXss1 needed by atom-beta-1.13.0.beta9-0.1.x86_64

1.12.7 is ok though

@ed-barberis

Same here, Oracle Linux 7.3: can't install 1.12.8:

# yum install atom.x86_64.rpm
Error: Package: atom-1.12.8-0.1.x86_64 (/atom.x86_64)
           Requires: libXss1

Seems like OL7 and centos7 should require libXScrnSaver like fedora and rhel. 1.12.7 worked, but required libXScrnSaver.i686 on x86_64 machines. 1.12.6 installed without any dependency issues.

Also, not allowing --assumeyes or -y breaks DevOps automation.

@iolsen iolsen added a commit that referenced this pull request Jan 4, 2017
@iolsen iolsen Revert "Merge pull request #13421 from philwyett-hemi/rpm_dev"
This reverts commit 206252c.
5995d34
@iolsen iolsen added a commit that referenced this pull request Jan 4, 2017
@iolsen iolsen Revert "Merge pull request #13421 from philwyett-hemi/rpm_dev"
This reverts commit 86e34d9.
0392222
@as-cii as-cii added a commit that referenced this pull request Jan 9, 2017
@as-cii as-cii Revert "Merge pull request #13421 from philwyett-hemi/rpm_dev"
This reverts commit 86e34d9.
dddd523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment