Switch to npm provided chromedriver instead of manually downloaded #13431

Merged
merged 3 commits into from Dec 13, 2016

Projects

None yet

1 participant

@damieng
Member
damieng commented Dec 13, 2016 edited

We manually download the Chromedriver using the GitHub API used for some of the Atom specs because previously that's all there was and presumably also because we only used it on the Mac.

Lately, it has been hitting the rate limit and these two conditions no longer exist so we can just install it via npm.

Update: Added a check to the build script to ensure when we update electron we don't forget to update the chromedriver as recommended by @nathansobo

damieng added some commits Dec 13, 2016
@damieng damieng Switch electron-chromedriver from GitHub download to npm install
f25a718
@damieng damieng Ensure chromedriver matches electron version during build
aa2b32e
@damieng damieng Do not use the chromedriver wrapper as it spews to stdout
438168e
@damieng damieng merged commit ad77c31 into master Dec 13, 2016

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@damieng damieng deleted the dg-use-npm-chromedriver branch Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment