Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Limit line decoration update to visible row range #13486
Previously, if we had selections exceeding the visible range we still add line decorations to the cache for every row in the selection, including rows that were off screen and not rendered. This resulted in massive slowdowns when rendering with a large selection.
Here's some profiles showing me scrolling a 250,000-line file with a single selection spanning the entire file.
Before this change, 500ms frames and terribleness:
After this change, the line decorations don't appear in the profile, frames down to ~10ms.