Don't hard-code "Atom.app" #13506

Merged
merged 1 commit into from Dec 28, 2016

Projects

None yet

2 participants

@ggreif
Contributor
ggreif commented Dec 27, 2016

and a few typos

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Alternate Designs

The change seems harmless, and makes reporting more exact.

Why Should This Be In Core?

Already in core

Benefits

User will get a lss confusing error message for Atom Beta

Possible Drawbacks

none

Applicable Issues

none known

@ggreif ggreif Don't hard-code "Atom.app"
and a few typos
e95b696
@damieng damieng merged commit ebdf27a into atom:master Dec 28, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment