Call debounced cursor blink resume callback any time the cursor moves #13539

Merged
merged 1 commit into from Jan 4, 2017

Projects

None yet

2 participants

@nathansobo
Contributor

Previously, we were only calling the debounced resume callback when the cursor was already blinking, but this meant we didn't renew the debounce window. This in turn meant we attempted to start blinking the cursor again every 100ms regardless of cursor interactions, which was consuming an extra frame and causing cursor movement to not feel smooth.

@nathansobo nathansobo Call debounced cursor blink resume callback any time the cursor moves
Previously, we were only calling the debounced resume callback when the
cursor was already blinking, but this meant we didn't renew the debounce
window. This in turn meant we attempted to start blinking the cursor
again every 100ms regardless of cursor interactions, which was consuming
an extra frame and causing cursor movement to not feel smooth.
3960a21
@maxbrunsfeld
Contributor
maxbrunsfeld commented Jan 4, 2017 edited

Appveyor failure is a known spurious thing (MenuManager).

@nathansobo
Contributor

Thanks for the heads-up @maxbrunsfeld.

@nathansobo nathansobo merged commit 6fb78bd into master Jan 4, 2017

3 of 5 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@nathansobo nathansobo deleted the ns-fix-cursor-blink-resume branch Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment