Add did-load-user-keymap event #13549

merged 2 commits into from Jan 6, 2017


None yet

1 participant

iolsen commented Jan 5, 2017 edited

Description of the Change

This change adds an event that fires after the user keymap has successfully loaded. It should be broadly useful in packages but is specifically being added in service of the MRU tab setting as described below.

Applicable Issues

This is necessary for adding an MRU tab traversal setting in a way that won't alter behavior for users who have already modified their keymaps to turn it off. At package init time the user keymap has not yet loaded so it's not possible to check for them.

@iolsen iolsen Add an event for after the user keymap has loaded.
@iolsen iolsen Basic test for user keymap loaded event
@iolsen iolsen added needs-review and removed work-in-progress labels Jan 6, 2017
@iolsen iolsen referenced this pull request in atom/tabs Jan 6, 2017

List view and option for MRU tab switching #388

@iolsen iolsen merged commit b6ecaf6 into master Jan 6, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
continuous-integration/appveyor/branch AppVeyor build succeeded
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
@iolsen iolsen deleted the io-user-keymap-event branch Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment