Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore correct directory's project state when opening a new file from the CLI #13810

Merged
merged 5 commits into from Feb 15, 2017

Conversation

@maxbrunsfeld
Copy link
Contributor

commented Feb 14, 2017

Fixes #13729

  • Ensure that the correct directory's state is loaded.
  • Remove duplication between AtomWindow constructor and AtomEnvironment.openLocations method.

☝️ We're going to defer this refactor until we take some time to rewrite the main process code.

Signed-off-by: Nathan Sobo <nathan@github.com>
On windows, because the path contains backslashes, evaling a string containing
the path can interpret the backslashes as escape sequences
@maxbrunsfeld maxbrunsfeld merged commit 97340ee into master Feb 15, 2017
2 of 5 checks passed
2 of 5 checks passed
ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@maxbrunsfeld maxbrunsfeld deleted the mb-fix-state-key-when-opening-new-files branch Feb 15, 2017
@50Wliu 50Wliu referenced this pull request Apr 2, 2017
1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.