Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for jasmine.any #13925

Merged
merged 5 commits into from Aug 6, 2019

Conversation

@UziTech
Copy link
Contributor

commented Mar 3, 2017

Description of the Change

Add back support for jasmine.any

Benefits

jasmine.any can be used in tests

Possible Drawbacks

none

@UziTech

This comment has been minimized.

Copy link
Contributor Author

commented Mar 3, 2017

sorry this is the wrong place to fix this

@UziTech UziTech closed this Mar 3, 2017

@UziTech

This comment has been minimized.

Copy link
Contributor Author

commented Mar 3, 2017

never mind this actually is probably the best way to fix this

@UziTech UziTech reopened this Mar 3, 2017

@UziTech UziTech force-pushed the UziTech:patch-1 branch from a0e696e to 4646e0d Mar 20, 2017

@50Wliu 50Wliu added the needs-review label Mar 23, 2017

@UziTech

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

still in needs-review

@jasonrudolph

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

👋 Hi @UziTech: Thanks for this pull request. When you have a moment, can you describe the process you followed to verify that your change has the desired effects?

Note: This information is something we've started requesting as part of the pull request template, but your pull request was opened prior to that change to the template. Nevertheless, it would be a big help if you could add this info to the pull request body.

Thanks for your help!

@UziTech UziTech force-pushed the UziTech:patch-1 branch from 4646e0d to 9bc83aa Aug 5, 2019

@UziTech

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

I added a test

jasonrudolph and others added some commits Aug 6, 2019

Fix typo in comment
Co-authored-by: Antonio Scandurra <as-cii@github.com>
Remove test that's testing a test helper
We appreciate the thoroughness, but we think it's OK to _not_ have this 
level of meta-testing at this point in the project.

Co-authored-by: Antonio Scandurra <as-cii@github.com>

@jasonrudolph jasonrudolph merged commit ef0581e into atom:master Aug 6, 2019

1 check passed

Atom Pull Requests #20190806.1 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.