New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app name to the Quit menu on macOS #14330

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Projects
None yet
3 participants
@sindresorhus
Contributor

sindresorhus commented Apr 30, 2017

@sindresorhus

This comment has been minimized.

Contributor

sindresorhus commented Oct 8, 2018

@50Wliu

This comment has been minimized.

Member

50Wliu commented Oct 8, 2018

Updated link. https://developer.apple.com/design/human-interface-guidelines/macos/menus/menu-bar-menus#app-menu

Should this display 'Quit Atom Beta', 'Quit Atom Dev', etc. for the relevant channels, or is just 'Quit Atom' good enough?

@sindresorhus

This comment has been minimized.

Contributor

sindresorhus commented Oct 9, 2018

@50Wliu I went with hardcoding the name as that's how it's done in the About Atom menu item.

@lee-dohm lee-dohm merged commit 4ca5d4e into atom:master Oct 15, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lee-dohm

This comment has been minimized.

Member

lee-dohm commented Oct 15, 2018

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment