Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd app name to the Quit menu on macOS #14330
+1
−1
Conversation
This comment has been minimized.
This comment has been minimized.
|
// @daviwil |
This comment has been minimized.
This comment has been minimized.
|
Updated link. https://developer.apple.com/design/human-interface-guidelines/macos/menus/menu-bar-menus#app-menu Should this display 'Quit Atom Beta', 'Quit Atom Dev', etc. for the relevant channels, or is just 'Quit Atom' good enough? |
This comment has been minimized.
This comment has been minimized.
|
@50Wliu I went with hardcoding the name as that's how it's done in the |
This comment has been minimized.
This comment has been minimized.
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
sindresorhus commentedApr 30, 2017
To adhere to the macOS Human Interface Guidelines: https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/MenuBarMenus.html