Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Enable MAX_SCREEN_LINE_LENGTH to now be set via a config option #14495
Description of the Change
This change enables the maximum softWrapColumn in the display layer object to be set using a configuration parameter rather than using the MAX_SCREEN_LINE_LENGTH constant. This value is returned by the getSoftWrapColumn function.
The default and minimum is still set at 500 to satisfy the design decision to address performance issues for those opening minified files, however it can be adjusted upwards for those who require a more flexible option.
As the getSoftWrapColumn function used a constant as the default return value, there are no alternate design options.
Why Should This Be In Core?
This needs to be in core as it is affecting the editor display layer parameters directly
Benefits are that the number of people who work with long line files that are not necessarily minified are able to customise their maximum width by the settings editor instead of using the constant value
Possible drawbacks are that a user sets the width high enough to cause performance issues with minified files, however this can be mitigated by reverting the setting to defaults in the editor settings
Related to: #13820
I think there should be two simple tests:
I left two small changes. Other than that, this looks great. Thanks!
Not sure what thee errors are as one looks like AppVeyor failed to install a module during the build that was not included in the build, and the CircleCI one is an internal eror for code signing. Any help on figuring these out would be appreiated as I can't see how they relate to the code updates