New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve confirm documentation #14654

Merged
merged 2 commits into from Sep 20, 2017

Conversation

Projects
None yet
2 participants
@UziTech
Contributor

UziTech commented May 26, 2017

Description of the Change

Updated atom.confirm documentation to include what happens if dialog is closed without selecting an option

Possible Drawbacks

I'm not 100% sure this is correct on all OSes

I had to do quite a bit of experimentation on Windows to figure out all the edge cases.

Most of the information I got from the dialog.showMessageBox documentation but there seems to be quite a few differences between Oses

UziTech added some commits May 26, 2017

@UziTech

This comment has been minimized.

Show comment
Hide comment
@UziTech

UziTech Sep 19, 2017

Contributor

Any reason this hasn't been merged?

Contributor

UziTech commented Sep 19, 2017

Any reason this hasn't been merged?

@rsese

This comment has been minimized.

Show comment
Hide comment
@rsese

rsese Sep 20, 2017

Member

Sorry for the delay here - we've since tweaked our process a bit to better track issues and PRs so hopefully things don't fall through the cracks like they did here.

Thanks for the update 🙇

Member

rsese commented Sep 20, 2017

Sorry for the delay here - we've since tweaked our process a bit to better track issues and PRs so hopefully things don't fall through the cracks like they did here.

Thanks for the update 🙇

@rsese rsese merged commit 7cb7b36 into atom:master Sep 20, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment