New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render line number gutter without numbers when showLineNumbers is false #14694

Merged
merged 1 commit into from Jun 1, 2017

Conversation

Projects
None yet
3 participants
@nathansobo
Contributor

nathansobo commented Jun 1, 2017

In #13880 we honored the lineNumberGutterVisible parameter but neglected to honor the showLineNumbers parameter, which is what is used by the text editor registry to interact with the settings. In the previous editor implementation, both of these options simply hid the line number completely. In this version, we've elected to handle showLineNumbers differently from lineNumberGutterVisible. We continue to render the line number gutter (which contains diff decorations, fold indicators, etc), but we just don't render the line numbers in it. This provides more features and a better visual experience when the line numbers are disabled.

馃崘ed with @as-cii

Render line number gutter without numbers when showLineNumbers is false
Signed-off-by: Nathan Sobo <nathan@github.com>

@as-cii as-cii merged commit 7b2a307 into master Jun 1, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@as-cii as-cii deleted the ns-as-fix-line-number-hiding branch Jun 1, 2017

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Jun 1, 2017

Member

@nathansobo Does this fix #3466?

Member

50Wliu commented Jun 1, 2017

@nathansobo Does this fix #3466?

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Jun 2, 2017

Member

Answering my own question...yes it does.

Member

50Wliu commented Jun 2, 2017

Answering my own question...yes it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment