New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native tabs on macOS #14711

Merged
merged 2 commits into from Aug 25, 2017

Conversation

Projects
None yet
10 participants
@simurai
Member

simurai commented Jun 3, 2017

Description of the Change

This enables native tabs on macOS. Under macOS > Menu > View there will be a "Show Tab Bar" option.

screen shot 2017-06-03 at 5 10 32 pm

Which lets you combine multiple Atom windows and tab between them:

native-tabs

Note: Only available if Atom > Settings > Core > Title Bar is set to native.

Alternate Designs

Was wondering if it should be a config, but I think it's not needed. Because:

  1. Electron is smart enough to only show the native tabs if there is also a native title bar. So issues with hidden/custom title bar shouldn't be a problem.

  2. You can control if Atom should open as a native tab or new window by going to macOS > System Preferences > Docks and change this:

    screen shot 2017-06-03 at 4 40 33 pm

Why Should This Be In Core?

It's part of the browserWindow options.

Benefits

Makes it possible to tab between multiple Atom windows.

Possible Drawbacks

People might not like this change if:

  1. They prefer opening as tabs for all other apps (like Finder), but not for Atom.
  2. They don't want to switch to a custom title bar.

Something else I noticed: If you have the DevTools open (as a separate window) and close the Atom window, the DevTools window moves as a tab to another existing Atom window. Not sure if that's an edge case to be ok with?

Applicable Issues

Closes #14197

@primalmotion

This comment has been minimized.

Show comment
Hide comment
@primalmotion

primalmotion Aug 1, 2017

simple and badly needed fix. Is there a way to hack this in without recompiling Atom?

primalmotion commented Aug 1, 2017

simple and badly needed fix. Is there a way to hack this in without recompiling Atom?

@rsese rsese referenced this pull request Aug 9, 2017

Closed

[1.19.0] [macOS] Atom CLI doesn't open native tabs #15202

1 of 1 task complete
@tsdorsey

This comment has been minimized.

Show comment
Hide comment
@tsdorsey

tsdorsey Aug 17, 2017

@simurai what kind of testing did you need done? I've running a local build of Atom based on on commit e48b980 with tabbing enabled via this method. Everything is working as expected.

The new window command line argument still works as expected.
The app responds to the dock setting for tabs as expected.

tsdorsey commented Aug 17, 2017

@simurai what kind of testing did you need done? I've running a local build of Atom based on on commit e48b980 with tabbing enabled via this method. Everything is working as expected.

The new window command line argument still works as expected.
The app responds to the dock setting for tabs as expected.

@simurai

This comment has been minimized.

Show comment
Hide comment
@simurai

simurai Aug 25, 2017

Member

@tsdorsey thanks for giving it another test run. I also merged in master and tried it again without issues.

AppVeyor fails, but I think it's unrelated 👇

Build execution time has reached the maximum allowed time for your plan (90 minutes).
Member

simurai commented Aug 25, 2017

@tsdorsey thanks for giving it another test run. I also merged in master and tried it again without issues.

AppVeyor fails, but I think it's unrelated 👇

Build execution time has reached the maximum allowed time for your plan (90 minutes).
@50Wliu

This comment has been minimized.

Show comment
Hide comment
Member

50Wliu commented Aug 25, 2017

@simurai simurai merged commit 80ce237 into master Aug 25, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simurai simurai deleted the sm-native-tabs branch Aug 25, 2017

@simurai

This comment has been minimized.

Show comment
Hide comment
@simurai

simurai Aug 25, 2017

Member

@50Wliu thanks.. 🙇 ok merged. 🚢 Will be in Atom 1.21.

Member

simurai commented Aug 25, 2017

@50Wliu thanks.. 🙇 ok merged. 🚢 Will be in Atom 1.21.

@calintat calintat referenced this pull request Sep 8, 2017

Closed

Custom title bar glitch #429

@TerrenceLJones

This comment has been minimized.

Show comment
Hide comment
@TerrenceLJones

TerrenceLJones Oct 3, 2017

I might have missed the discussion around this, but how do you cycle through the Atom native panes? cmd-shift-{ / cmd-shift-} do not cycle through native panes, but navigate through Atom panes (as was the case before this change). Is there currently a way to cycle through the native Atom panes? And if not, is there a plan to add support for this? Thanks, super excited about this feature!

TerrenceLJones commented Oct 3, 2017

I might have missed the discussion around this, but how do you cycle through the Atom native panes? cmd-shift-{ / cmd-shift-} do not cycle through native panes, but navigate through Atom panes (as was the case before this change). Is there currently a way to cycle through the native Atom panes? And if not, is there a plan to add support for this? Thanks, super excited about this feature!

@rsese

This comment has been minimized.

Show comment
Hide comment
@rsese

rsese Oct 3, 2017

Member

As far as I can tell, Atom doesn't currently support switching between native tabs with some command that you can add a keybinding for - can you open an issue for this @TerrenceLJones and fill out the issue template as much as possible so we can track it?

Member

rsese commented Oct 3, 2017

As far as I can tell, Atom doesn't currently support switching between native tabs with some command that you can add a keybinding for - can you open an issue for this @TerrenceLJones and fill out the issue template as much as possible so we can track it?

@mpacer

This comment has been minimized.

Show comment
Hide comment
@mpacer

mpacer Oct 4, 2017

The native tabs also seem to open in unpredictable ways… (sometimes things are opened in new atom tabs sometimes in new native tabs, each with their own set of atom tabs)…

what is the setting to choose to get back the previous default behaviour?

mpacer commented Oct 4, 2017

The native tabs also seem to open in unpredictable ways… (sometimes things are opened in new atom tabs sometimes in new native tabs, each with their own set of atom tabs)…

what is the setting to choose to get back the previous default behaviour?

@loadingwyn

This comment has been minimized.

Show comment
Hide comment
@loadingwyn

loadingwyn Oct 4, 2017

There is no "Show Tab Bar" option under View. I'm sure my Title Bar is set to native.

Versions

Atom : 1.21.0
OS: MacOS 10.13

loadingwyn commented Oct 4, 2017

There is no "Show Tab Bar" option under View. I'm sure my Title Bar is set to native.

Versions

Atom : 1.21.0
OS: MacOS 10.13

@rsese

This comment has been minimized.

Show comment
Hide comment
@rsese

rsese Oct 5, 2017

Member

what is the setting to choose to get back the previous default behaviour?

There was no config added (see #14711 for the rationale) so I believe Atom will follow whatever you have set in macOS > System Preferences > Docks. As mentioned in the PR, if you have Settings > Core > Title Bar set to anything besides native, Atom also won't use native tabs in this case.

There is no "Show Tab Bar" option under View. I'm sure my Title Bar is set to native.

I don't have 10.13 to test on but I can confirm that it's available on 10.12.6. @ungb do you have High Sierra installed to check?

Member

rsese commented Oct 5, 2017

what is the setting to choose to get back the previous default behaviour?

There was no config added (see #14711 for the rationale) so I believe Atom will follow whatever you have set in macOS > System Preferences > Docks. As mentioned in the PR, if you have Settings > Core > Title Bar set to anything besides native, Atom also won't use native tabs in this case.

There is no "Show Tab Bar" option under View. I'm sure my Title Bar is set to native.

I don't have 10.13 to test on but I can confirm that it's available on 10.12.6. @ungb do you have High Sierra installed to check?

@ungb

This comment has been minimized.

Show comment
Hide comment
@ungb

ungb Oct 5, 2017

Contributor

I don't have a high sierra just 10.12.6.

@lee-dohm can you check this if you have mac OSX 10.13?

Contributor

ungb commented Oct 5, 2017

I don't have a high sierra just 10.12.6.

@lee-dohm can you check this if you have mac OSX 10.13?

@lee-dohm

This comment has been minimized.

Show comment
Hide comment
@lee-dohm

lee-dohm Oct 5, 2017

Member

With "Title Bar" set to native ...

screen shot 2017-10-05 at 7 53 49 am

☝️ using Atom v1.23.0-dev-c9c495792 on Mac OS X 10.13

screen shot 2017-10-05 at 7 55 27 am

☝️ using Atom v1.21.0 on Mac OS X 10.13

Member

lee-dohm commented Oct 5, 2017

With "Title Bar" set to native ...

screen shot 2017-10-05 at 7 53 49 am

☝️ using Atom v1.23.0-dev-c9c495792 on Mac OS X 10.13

screen shot 2017-10-05 at 7 55 27 am

☝️ using Atom v1.21.0 on Mac OS X 10.13

@lee-dohm

This comment has been minimized.

Show comment
Hide comment
@lee-dohm

lee-dohm Oct 5, 2017

Member

@loadingwyn and others ... If you have what you believe to be a bug, please open a new issue and fill in the issue template with as much detail as you can. All of this discussion is not related to the PR.

Member

lee-dohm commented Oct 5, 2017

@loadingwyn and others ... If you have what you believe to be a bug, please open a new issue and fill in the issue template with as much detail as you can. All of this discussion is not related to the PR.

@rsese rsese referenced this pull request Oct 6, 2017

Open

missing "Show Tab Bar" on MacOS 10.13 #15832

1 of 1 task complete

@jasonrudolph jasonrudolph referenced this pull request May 8, 2018

Merged

Upgrade to Electron 2.0.0 #17273

60 of 60 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment