New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved clarity of Editor not responding actions #14753

Merged
merged 1 commit into from Jun 12, 2017

Conversation

Projects
None yet
3 participants
@tjkohli
Contributor

tjkohli commented Jun 10, 2017

Description of the Change

Changed the label on the positive button of the "Editor is not responding" alert dialog from "Close" to "Force Close" because "Close" might imply closing the Alert/Dialog instead of the editor, whereas "Force Close" better describes the action that button will take.

Alternate Designs

Other strings may be "Force Quit" or "End Process" or "Close Editor"

Why Should This Be In Core?

This change is a tweak to the core strings.

Benefits

Makes a (minor) improvement to user experience and reduces decision fatigue for end users.

Possible Drawbacks

Slight (neglibile) increase in file size due to longer string.

Applicable Issues

Translation/localization will need to be updated elsewhere.

Improved clarity of Editor not responding actions
Changed "Close" to "Force Close" because "Close" might imply closing the Alert/Dialog instead of the editor, whereas "Force Close" better describes the action that button will take.
@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Jun 12, 2017

Member

Gets a 👍 from me. Anyone from @atom/feedback opposed?

Member

50Wliu commented Jun 12, 2017

Gets a 👍 from me. Anyone from @atom/feedback opposed?

@lee-dohm lee-dohm merged commit 6edf659 into atom:master Jun 12, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lee-dohm

This comment has been minimized.

Show comment
Hide comment
@lee-dohm

lee-dohm Jun 12, 2017

Member

Sounds like a great change to me! Thanks for the contribution @tjkohli 🎉

Member

lee-dohm commented Jun 12, 2017

Sounds like a great change to me! Thanks for the contribution @tjkohli 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment