Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix dock button rendering issue #14998
Description of the Change
This promotes the
Why Should This Be In Core?
It's where the dock styles live.
Fixes this rendering issue: #14915
Forcing layers could have some side effects elsewhere.
My repro: close and reopen Atom manually, black bars appear
Note that the edge of the dock is a little messed up (i.e. has some artifacts that I don't believe were there before), but there are no black bars anymore (persists through restarts).
It should be also noted that the thin, black line to the right of the gray one is there because my screenshot bled over to the other monitor. The artifacts I'm referring to are the thin, gray line to the right of the image, as well as whatever is going on at the top of the minimap.
referenced this pull request
Aug 18, 2017
@Arcanemagus thanks for verifying! I've tested this as well and looks good to me. I was able to see the issue before and fixed afterwards.
@simurai regarding your comment:
It seems this css style is only on the class
Well, it looks like currently there is a big layer that gets removed, once