New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the fs.existsSync guard in Config #15656

Merged
merged 1 commit into from Sep 15, 2017

Conversation

Projects
None yet
1 participant
@smashwilson
Member

smashwilson commented Sep 15, 2017

season 6.0.0's CSON.writeFileSync method didn't have a third "options" argument, so if this code is executed with an old version of season, it will always unconditionally wipe the config. This can happen if, for example, you open Atom in developer mode after doing a git pull in your Atom directory but before running a script/build to update the dependencies.

/cc @BinaryMuse @damieng @kuychaco

@smashwilson smashwilson merged commit a01e495 into master Sep 15, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw-extra-write-guard branch Sep 15, 2017

smashwilson added a commit that referenced this pull request Sep 15, 2017

Merge pull request #15656 from atom/aw-extra-write-guard
Restore the fs.existsSync guard in Config

smashwilson added a commit that referenced this pull request Sep 15, 2017

Merge pull request #15656 from atom/aw-extra-write-guard
Restore the fs.existsSync guard in Config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment