New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pane on did change path #15692

Merged
merged 5 commits into from Sep 28, 2017

Conversation

Projects
None yet
5 participants
@UziTech
Contributor

UziTech commented Sep 19, 2017

Description of the Change

Change a pane elements .dataset.activeItemPath and .dataset.activeItemName when the path changes.

Alternate Designs

Why Should This Be In Core?

needs to change the core pane-element

Benefits

atom.workspace.getActivePane().element.dataset.activeItemPath

will be more reliable.

Possible Drawbacks

none

Applicable Issues

#15691

@danish-imam

This comment has been minimized.

Show comment
Hide comment
@danish-imam

danish-imam Sep 21, 2017

can someone please help on how to start contributing (I am new to Open Source) :)

danish-imam commented Sep 21, 2017

can someone please help on how to start contributing (I am new to Open Source) :)

@UziTech

This comment has been minimized.

Show comment
Hide comment
Contributor

UziTech commented Sep 21, 2017

@50Wliu 50Wliu added the needs-review label Sep 21, 2017

@maxbrunsfeld

This comment has been minimized.

Show comment
Hide comment
@maxbrunsfeld

maxbrunsfeld Sep 28, 2017

Contributor

Great work @UziTech; thanks for fixing this!

Contributor

maxbrunsfeld commented Sep 28, 2017

Great work @UziTech; thanks for fixing this!

@maxbrunsfeld maxbrunsfeld merged commit 969cb7a into atom:master Sep 28, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@UziTech UziTech referenced this pull request Oct 6, 2017

Closed

change activeItemPath when file is renamed #15691

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment