New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore a missing "typeof" #15740

merged 1 commit into from Sep 25, 2017


None yet
1 participant

smashwilson commented Sep 25, 2017

The deactivationResult returned from a package's deactivate() method was having its then property compared to the string "function" rather than its type being compared to "function". As a result, async package deactivation functions were not returning the correct Promise from PackageManager.deactivatePackage().

Quick fix ⚡️

@smashwilson smashwilson merged commit e38ae91 into master Sep 25, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@smashwilson smashwilson deleted the aw-missing-typeof branch Sep 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment