New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix faded application icons on macOS 10.13 #15760

Merged
merged 1 commit into from Sep 30, 2017

Conversation

Projects
None yet
4 participants
@thomasjo
Member

thomasjo commented Sep 27, 2017

Description of the Change

Something changed in macOS 10.13 High Sierra that affects how our application icons render. Simply regenerating the .icns files based on the PNG master files using iconutil fixes the issue. I am however not able to verify if they still look as intended on macOS 10.12 (and older).

Alternate Designs

Will have to ship separate icon set for macOS 10.13 if this does not work as intended on older releases of macOS.

Why Should This Be In Core?

Icon resources reside in this repo.

Benefits

Application icons look like they should — not washed out.

Possible Drawbacks

Might break icons on macOS versions older than 10.13.

Applicable Issues

Fixes #15410

@thomasjo thomasjo requested a review from simurai Sep 27, 2017

@thomasjo thomasjo added mac ui labels Sep 27, 2017

@thomasjo thomasjo referenced this pull request Sep 27, 2017

Closed

Icons display incorrectly on macOS High Sierra #15410

1 of 1 task complete
@lee-dohm

This comment has been minimized.

Show comment
Hide comment
@lee-dohm

lee-dohm Sep 28, 2017

Member

@ungb Can you test this on a version of macOS 10.12.x or earlier?

Member

lee-dohm commented Sep 28, 2017

@ungb Can you test this on a version of macOS 10.12.x or earlier?

@ungb

This comment has been minimized.

Show comment
Hide comment
@ungb

ungb Sep 29, 2017

Contributor

tested on mac 1.12.6:
Dev:
image
Beta:

image

Stable:
image

LGTM! 🚢

Contributor

ungb commented Sep 29, 2017

tested on mac 1.12.6:
Dev:
image
Beta:

image

Stable:
image

LGTM! 🚢

@thomasjo thomasjo merged commit f2f8414 into master Sep 30, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@thomasjo thomasjo deleted the tj-update-macos-icons branch Sep 30, 2017

@Ben3eeE

This comment has been minimized.

Show comment
Hide comment
@Ben3eeE

Ben3eeE Sep 30, 2017

Member

🎉

Member

Ben3eeE commented Sep 30, 2017

🎉

thomasjo added a commit that referenced this pull request Oct 3, 2017

Merge pull request #15760 from atom/tj-update-macos-icons
Fix faded application icons on macOS 10.13

thomasjo added a commit that referenced this pull request Oct 3, 2017

Merge pull request #15760 from atom/tj-update-macos-icons
Fix faded application icons on macOS 10.13

nathansobo added a commit that referenced this pull request Oct 3, 2017

Merge pull request #15760 from atom/tj-update-macos-icons
Fix faded application icons on macOS 10.13

nathansobo added a commit that referenced this pull request Oct 3, 2017

Merge pull request #15760 from atom/tj-update-macos-icons
Fix faded application icons on macOS 10.13

@sethlu sethlu referenced this pull request Nov 19, 2017

Merged

fix: Update icns #11168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment