New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the stale markComment message #15775

Merged
merged 3 commits into from Oct 5, 2017

Conversation

Projects
None yet
4 participants
@Ben3eeE
Member

Ben3eeE commented Sep 29, 2017

This is a first draft including what I would like to add to the bot message after reading feedback.

/cc: @lee-dohm @rsese for 馃挱s about the wording and contents.

@Ben3eeE Ben3eeE requested a review from lee-dohm Sep 29, 2017

@Ben3eeE

This comment has been minimized.

Show comment
Hide comment
@Ben3eeE
Member

Ben3eeE commented Sep 29, 2017

/cc: @50Wliu

Show outdated Hide outdated .github/stale.yml Outdated
Show outdated Hide outdated .github/stale.yml Outdated
* What OS and version you reproduced the issue on
* What steps you followed to reproduce the issue
Issues that are labeled as triaged will not be automatically marked as stale.

This comment has been minimized.

@50Wliu

50Wliu Oct 3, 2017

Member

Is this necessary?

@50Wliu

50Wliu Oct 3, 2017

Member

Is this necessary?

This comment has been minimized.

@lee-dohm

lee-dohm Oct 3, 2017

Member

Not necessary, though @Ben3eeE felt that it would be helpful because it is a common question.

@lee-dohm

lee-dohm Oct 3, 2017

Member

Not necessary, though @Ben3eeE felt that it would be helpful because it is a common question.

This comment has been minimized.

@Ben3eeE

Ben3eeE Oct 3, 2017

Member

Yeah there was some confusion around this. Like "This is labeled as bug does that mean...". I don't think it hurts to be explicit about it so that users will know. We do also not automatically close security and regression labeled issues but I intentionally left those out because then it was too complicated and getting your issue labeled as triaged seems like the most common thing to prevent the bot from automatically closing it.

@Ben3eeE

Ben3eeE Oct 3, 2017

Member

Yeah there was some confusion around this. Like "This is labeled as bug does that mean...". I don't think it hurts to be explicit about it so that users will know. We do also not automatically close security and regression labeled issues but I intentionally left those out because then it was too complicated and getting your issue labeled as triaged seems like the most common thing to prevent the bot from automatically closing it.

@Ben3eeE

This comment has been minimized.

Show comment
Hide comment
@Ben3eeE

Ben3eeE Oct 3, 2017

Member

I think the changes made are good 馃憤 Thank you @lee-dohm and @50Wliu for reviewing 馃檱

Member

Ben3eeE commented Oct 3, 2017

I think the changes made are good 馃憤 Thank you @lee-dohm and @50Wliu for reviewing 馃檱

recent activity. Because the Atom team treats their issues
[as their backlog](https://en.wikipedia.org/wiki/Scrum_(software_development)#Product_backlog), stale issues
are closed. If you would like this issue to remain open:

This comment has been minimized.

@rsese

rsese Oct 3, 2017

Member

鉂わ笍 I feel like that was a big issue for people. Even though it was implied that more activity would keep it open, I like us being explicit and saying "here's what you can do if you want this to stay open".

@rsese

rsese Oct 3, 2017

Member

鉂わ笍 I feel like that was a big issue for people. Even though it was implied that more activity would keep it open, I like us being explicit and saying "here's what you can do if you want this to stay open".

@lee-dohm

This comment has been minimized.

Show comment
Hide comment
@lee-dohm

lee-dohm Oct 5, 2017

Member

Sounds like everyone is generally 馃憤 on this change, so I'm going to merge it. Thanks for taking this on @Ben3eeE 馃檱

Member

lee-dohm commented Oct 5, 2017

Sounds like everyone is generally 馃憤 on this change, so I'm going to merge it. Thanks for taking this on @Ben3eeE 馃檱

@lee-dohm lee-dohm merged commit 85ea192 into master Oct 5, 2017

2 of 3 checks passed

ci/circleci Your tests failed on CircleCI
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lee-dohm lee-dohm deleted the b3-stale-message branch Oct 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment