New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mouseup listener cleanup when dragging in text editor #15777

Merged
merged 1 commit into from Sep 29, 2017

Conversation

Projects
None yet
3 participants
@matthewwithanm
Member

matthewwithanm commented Sep 29, 2017

This listener is added with {capture: true}, which means it'll only be removed if removeEventListener() is passed {capture: true} too. Without that (as it is currently), the listener is never removed and each mouseup event ends up triggering the handler one more time than the last. Eventually, this leads to slowdown. 馃槥

@maxbrunsfeld maxbrunsfeld merged commit 0066ccf into master Sep 29, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxbrunsfeld maxbrunsfeld deleted the fb-mdt-fix-mouseup-cleanup branch Sep 29, 2017

@maxbrunsfeld

This comment has been minimized.

Show comment
Hide comment
@maxbrunsfeld

maxbrunsfeld Sep 29, 2017

Contributor

Thanks for the fix!

Contributor

maxbrunsfeld commented Sep 29, 2017

Thanks for the fix!

@nathansobo

This comment has been minimized.

Show comment
Hide comment
@nathansobo

nathansobo Sep 29, 2017

Contributor

@maxbrunsfeld do you think we should hot-fix this?

Contributor

nathansobo commented Sep 29, 2017

@maxbrunsfeld do you think we should hot-fix this?

maxbrunsfeld added a commit that referenced this pull request Sep 29, 2017

Merge pull request #15777 from atom/fb-mdt-fix-mouseup-cleanup
Fix mouseup listener cleanup when dragging in text editor

maxbrunsfeld added a commit that referenced this pull request Sep 29, 2017

Merge pull request #15777 from atom/fb-mdt-fix-mouseup-cleanup
Fix mouseup listener cleanup when dragging in text editor

maxbrunsfeld added a commit that referenced this pull request Sep 29, 2017

Merge pull request #15777 from atom/fb-mdt-fix-mouseup-cleanup
Fix mouseup listener cleanup when dragging in text editor
@maxbrunsfeld

This comment has been minimized.

Show comment
Hide comment
@maxbrunsfeld

maxbrunsfeld Sep 29, 2017

Contributor

Yeah. Just cherry-picked it to all the release branches.

Contributor

maxbrunsfeld commented Sep 29, 2017

Yeah. Just cherry-picked it to all the release branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment