New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:art: Shortened last three methods in color class #15785

Merged
merged 1 commit into from Oct 2, 2017

Conversation

Projects
None yet
2 participants
@arnavb
Contributor

arnavb commented Oct 1, 2017

Used the ternary operator to shorten the last three methods in color.js

Description of the Change

This was a small refactoring to shorten the last three methods in the color class.

Alternate Designs

N/A

Why Should This Be In Core?

N/A

Benefits

It doesn't sacrifice clarity, but just reduces unnecessary sizeof code.

Possible Drawbacks

Possibly readability, although that shouldn't be too big an issue.

Applicable Issues

None

Shortened last three methods in color class
Used the ternary operator to shorten the last three methods in color.js

@arnavb arnavb changed the title from Shortened last three methods in color class to :art: Shortened last three methods in color class Oct 1, 2017

@maxbrunsfeld maxbrunsfeld merged commit c30cc9b into atom:master Oct 2, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@maxbrunsfeld

This comment has been minimized.

Show comment
Hide comment
@maxbrunsfeld

maxbrunsfeld Oct 2, 2017

Contributor

👍

Contributor

maxbrunsfeld commented Oct 2, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment