New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt to save when unloading if editor is in conflict #15798

Merged
merged 1 commit into from Oct 3, 2017

Conversation

Projects
None yet
1 participant
@maxbrunsfeld
Contributor

maxbrunsfeld commented Oct 3, 2017

Refs #15791

Normally we don't prompt to save editors when reloading or closing a window. But if an editor's contents have changed on disk, then we would need to save the editor to avoid data loss.

I'm not positive that this is the best solution, but it seems reasonable to let you know that if you don't save, you'll lose your changes. Ultimately, we need a little more UI to surface the fact that the editor has changed on disk.

@maxbrunsfeld maxbrunsfeld merged commit c461409 into master Oct 3, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-prompt-to-save-in-conflict branch Oct 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment