New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve indentation when toggling comments on whitespace-only lines #15799

Merged
merged 2 commits into from Oct 3, 2017

Conversation

Projects
None yet
1 participant
@maxbrunsfeld
Contributor

maxbrunsfeld commented Oct 3, 2017

Fixes a regression introduced in #15713.

When toggling comments on whitespace-only lines, we need to preserve the indentation level.

/cc @jasonrudolph

@maxbrunsfeld maxbrunsfeld merged commit c75fe18 into master Oct 3, 2017

0 of 3 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-fix-commenting-empty-lines branch Oct 3, 2017

@Ben3eeE Ben3eeE referenced this pull request Oct 9, 2017

Closed

Toggle line comments on blank line indents incorrectly #15850

1 of 1 task complete

maxbrunsfeld added a commit that referenced this pull request Oct 9, 2017

Merge pull request #15799 from atom/mb-fix-commenting-empty-lines
Preserve indentation when toggling comments on whitespace-only lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment