New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indentation to force YAML to leave certain lines the way they are #15840

Merged
merged 1 commit into from Oct 7, 2017

Conversation

Projects
None yet
2 participants
@lee-dohm
Member

lee-dohm commented Oct 7, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Stale bot was posting comments that looked wonky:

screen shot 2017-10-07 at 1 01 15 pm

This should fix it so that they look the way they were intended to look.

Alternate Designs

Another possibility is to use the literal scalar syntax | in the place of >:

markComment: |
  Thanks for your contribution!
   
  This issue has been automatically marked as stale because it has not had recent activity. Because the Atom team treats their issues [as their backlog](https://en.wikipedia.org/wiki/Scrum_(software_development)#Product_backlog), stale issues are closed. 

  If you would like this issue to remain open:
   
  1. Verify that you can still reproduce the issue in the latest version of Atom
  1. Comment that the issue is still reproducible and include:
      * What version of Atom you reproduced the issue on
      * What OS and version you reproduced the issue on
      * What steps you followed to reproduce the issue
   
  Issues that are labeled as triaged will not be automatically marked as stale.

but that means the second paragraph would have to be one long line and that makes the file less readable, I think.

Why Should This Be In Core?

It already is.

Benefits

No more wonky looking Stale bot comments.

Possible Drawbacks

None that I can think of.

Applicable Issues

N/A

@lee-dohm lee-dohm merged commit 26b784d into master Oct 7, 2017

0 of 3 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@lee-dohm lee-dohm deleted the fix-stale-indentation branch Oct 7, 2017

@InsertPunHere1

This comment has been minimized.

Show comment
Hide comment
@InsertPunHere1

InsertPunHere1 commented on 359e6b9 Mar 13, 2018

🥇

This comment has been minimized.

Show comment
Hide comment
@InsertPunHere1

InsertPunHere1 replied Mar 13, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment