Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Don't throw when destroying block decorations inside marker change event #15865
Previously, when markers were destroyed inside of a
This was a little counterintuitive at first, because we were already disposing the change event handler associated with the marker upon its destruction. However, we would still receive a marker change event because the marker was getting destroyed while notifying its change event subscribers.
With this pull-request we will gracefully handle that situation by remembering that the marker became invalid during its destruction, so that when the change event is finally triggered, it will simply be ignored because the marker validity will not change.