New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to more accurate local dev instructions #15904

Merged
merged 1 commit into from Oct 16, 2017

Conversation

Projects
None yet
2 participants
@laurmurclar
Contributor

laurmurclar commented Oct 16, 2017

Description of the Change

The Flight Manual contains more accurate instructions for local development on official Atom packages. This change links to these instructions rather than duplicating them in the repo.

Benefits

We won't have to try keep both versions of the instructions in sync. I was caught out by this (as you can see in atom/bracket-matcher#306) so I'm changing it for future contributors 馃槉

Link to more accurate local dev instructions
The Flight Manual contains more accurate instructions for local development on official Atom packages. I was caught out by this (as you can see in atom/bracket-matcher#306) so I'm changing it for future contributors. 馃槉 I think it's better to just link to the Flight Manual rather than maintaining the instructions in two places.
@laurmurclar

This comment has been minimized.

Show comment
Hide comment
@laurmurclar

laurmurclar Oct 16, 2017

Contributor

@Ben3eeE the PR we talked about 馃槃

Contributor

laurmurclar commented Oct 16, 2017

@Ben3eeE the PR we talked about 馃槃

```
By running Atom with the `-d` flag, you signal it to run with development packages installed. `apm link` makes sure that your local repository is loaded by Atom.
All packages can be developed locally. For instructions on how to do this, see [Contributing to Official Atom Packages][contributing-to-official-atom-packages] in the [Atom Flight Manual](http://flight-manual.atom.io).

This comment has been minimized.

@Ben3eeE

Ben3eeE Oct 16, 2017

Member

@ungb @rsese We should add documentation for Local development of Atom Core here (Or link to the not yet existing section in the flight-manual)

I opened an issue atom/flight-manual.atom.io#382 鈿★笍

@Ben3eeE

Ben3eeE Oct 16, 2017

Member

@ungb @rsese We should add documentation for Local development of Atom Core here (Or link to the not yet existing section in the flight-manual)

I opened an issue atom/flight-manual.atom.io#382 鈿★笍

@Ben3eeE Ben3eeE merged commit be61d6d into atom:master Oct 16, 2017

1 of 3 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Ben3eeE

This comment has been minimized.

Show comment
Hide comment
@Ben3eeE

Ben3eeE Oct 16, 2017

Member

@laurmurclar Thanks for contributing 馃挴 馃檱

Member

Ben3eeE commented Oct 16, 2017

@laurmurclar Thanks for contributing 馃挴 馃檱

@laurmurclar laurmurclar deleted the laurmurclar:patch-1 branch Oct 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment