New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:arrow_up: language-perl@0.38.0 #15939

Merged
merged 1 commit into from Oct 19, 2017

Conversation

Projects
None yet
2 participants
@Fank
Member

Fank commented Oct 19, 2017

This change include 2 large PRs which will improve perl language a lot.

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Oct 19, 2017

Member

⚡️

Member

50Wliu commented Oct 19, 2017

⚡️

@50Wliu 50Wliu merged commit cee38a4 into master Oct 19, 2017

0 of 3 checks passed

ci/circleci Your tests failed on CircleCI
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@50Wliu 50Wliu deleted the fk_update_perl branch Oct 19, 2017

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Oct 19, 2017

Member

@Fank I pressed the merge button too early. There's a failing test on CircleCI: https://circleci.com/gh/atom/atom/5668

Member

50Wliu commented Oct 19, 2017

@Fank I pressed the merge button too early. There's a failing test on CircleCI: https://circleci.com/gh/atom/atom/5668

50Wliu added a commit that referenced this pull request Oct 19, 2017

Revert "Merge pull request #15939 from atom/fk_update_perl"
This reverts commit cee38a4, reversing
changes made to 53203e7.
@Fank

This comment has been minimized.

Show comment
Hide comment
@Fank

Fank Oct 19, 2017

Member

Will check tomorrow don't have time for it now, revert it if you dont want to wait.

Member

Fank commented Oct 19, 2017

Will check tomorrow don't have time for it now, revert it if you dont want to wait.

@Fank

This comment has been minimized.

Show comment
Hide comment
@Fank

Fank Oct 20, 2017

Member

@50Wliu the failing test is a "Error: connect ETIMEDOUT 52.216.0.208:443"
doesn't look like related to the version bumb

Member

Fank commented Oct 20, 2017

@50Wliu the failing test is a "Error: connect ETIMEDOUT 52.216.0.208:443"
doesn't look like related to the version bumb

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Oct 20, 2017

Member

This is the error I'm seeing:

Package tests failed for language-perl:
....................................................F................................................

Perl grammar
  when encountering `v` followed by dot-delimited digits
    it tokenises it as a version literal
      Expected undefined to equal { value : '', scopes : [ 'source.perl', 'meta.preprocessor.pragma.perl' ] }.
        at jasmine.Spec.<anonymous> (/Users/distiller/atom/node_modules/language-perl/spec/grammar-spec.coffee:693:27)
Member

50Wliu commented Oct 20, 2017

This is the error I'm seeing:

Package tests failed for language-perl:
....................................................F................................................

Perl grammar
  when encountering `v` followed by dot-delimited digits
    it tokenises it as a version literal
      Expected undefined to equal { value : '', scopes : [ 'source.perl', 'meta.preprocessor.pragma.perl' ] }.
        at jasmine.Spec.<anonymous> (/Users/distiller/atom/node_modules/language-perl/spec/grammar-spec.coffee:693:27)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment