New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use endsWith to match modules to exclude from the snapshot #15945

merged 1 commit into from Oct 22, 2017


None yet
2 participants

50Wliu commented Oct 19, 2017


  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

There's a couple of common packages that need to be excluded from the snapshot. Rather than listing each instance (since they may or may not be deduped), match using endsWith.

Alternate Designs


Why Should This Be In Core?

Already is.


Less code maintenance if a package is un-deduped or a new dependency of that package is added in a different module. Also fixes an intermittent build issue for me where an additional fs-extra shows up in github/node_modules/nsfw/node_modules/fs-extra.

Possible Drawbacks


Applicable Issues


/cc @as-cii just wanted to make sure this is safe to do.

@as-cii as-cii merged commit 43ec519 into master Oct 22, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@as-cii as-cii deleted the wl-smarter-snapshot-exclusion branch Oct 22, 2017


This comment has been minimized.

Show comment
Hide comment

as-cii Oct 22, 2017


Looks good, thanks!


as-cii commented Oct 22, 2017

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment