New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move `toggleLineComments` method from TokenizedBuffer to TextEditor #15977

Merged
merged 3 commits into from Oct 24, 2017

Conversation

Projects
None yet
1 participant
@maxbrunsfeld
Contributor

maxbrunsfeld commented Oct 24, 2017

Depends on atom/text-buffer#260
Continues work started in #15713

As part of this, I have changed toggleLineCommentsForBufferRows to not require oniguruma. Going forward TokenizedBuffer (which will later be renamed to TextMateLanguageMode or something) will be the only component of Atom that relies on oniguruma.

@maxbrunsfeld maxbrunsfeld changed the title from Update syntax-related code to use new TextBuffer LanguageMode API (part 2) to Move `toggleLineComments` method from TokenizedBuffer to TextEditor Oct 24, 2017

@maxbrunsfeld maxbrunsfeld merged commit 9a95372 into master Oct 24, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-use-language-modes branch Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment