New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assign a default project path for package specs that don't have a fixtures directory #15990

Merged
merged 1 commit into from Oct 25, 2017

Conversation

Projects
None yet
1 participant
@nathansobo
Contributor

nathansobo commented Oct 25, 2017

References atom/spell-check#223, but it won't fix it until this PR is hotfixed to stable.

This prevents package specs that don't have a fixtures directory from attempting to read files out of a non-existent directory inside the ASAR bundle, which causes ENOTDIR errors in superstring.

If the spec does not have a parent folder containing a fixtures directory, we now set the default project path to os.tmpdir().

Always assign a project path outside of bundle for legacy package specs
This prevents package specs that don't have a fixtures directory from
attempting to read files out of a non-existent directory inside the ASAR
bundle, which causes ENOTDIR errors in superstring.

If the spec does not have a parent folder containing a fixtures
directory, we now set the default project path to `os.tmpdir()`.

@nathansobo nathansobo merged commit d44d6ab into master Oct 25, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nathansobo nathansobo deleted the non-asar-legacy-spec-project-path branch Oct 25, 2017

nathansobo added a commit that referenced this pull request Oct 25, 2017

Merge pull request #15990 from atom/non-asar-legacy-spec-project-path
Don't assign a default project path for package specs that

nathansobo added a commit that referenced this pull request Oct 25, 2017

Merge pull request #15990 from atom/non-asar-legacy-spec-project-path
Don't assign a default project path for package specs that

@iolsen iolsen changed the title from Don't assign a default project path for package specs that to Don't assign a default project path for package specs that don't have a fixtures directory Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment