New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to fork of nsfw to fix symlink loops on Linux #16017

Merged
merged 2 commits into from Oct 28, 2017

Conversation

Projects
None yet
1 participant
@nathansobo
Contributor

nathansobo commented Oct 27, 2017

Fixes #15966

This PR switches to a new fork of nsfw that incorporates the changes made in Axosoft/nsfw#41 to avoid endless loops when constructing watch trees for directories containing recursive symbolic links on Linux. We can switch back to the main nsfw if that PR gets merged.

/cc @ungb @Ben3eeE in case you want to test this out on projects recursive symbolic links in Linux. A good way to test would be to just add a recursive link inside the atom/atom repo.

@nathansobo nathansobo merged commit 9097c9a into master Oct 28, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nathansobo nathansobo deleted the switch-to-nsfw-fork branch Oct 28, 2017

nathansobo added a commit that referenced this pull request Oct 28, 2017

Merge pull request #16017 from atom/switch-to-nsfw-fork
Switch to fork of nsfw to fix symlink loops on Linux

nathansobo added a commit that referenced this pull request Oct 28, 2017

Merge pull request #16017 from atom/switch-to-nsfw-fork
Switch to fork of nsfw to fix symlink loops on Linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment