New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve spec reporter #16058

Merged
merged 2 commits into from Nov 1, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Nov 1, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

  • Preserve whitespace in failure messages. Prevents the following from happening:
    collapsed-whitespace
  • Do not modify menus. Prevents Atom's menus from changing into just A -> B.

Alternate Designs

I'm unsure whether to use pre-wrap or pre. Since pre-wrap appears to be the more conservative option, I'm going to stick with that until there's a spec that is easier to read with pre.

Why Should This Be In Core?

Take a wild guess.

Benefits

Less frustration when running specs.

Possible Drawbacks

N/A

Applicable Issues

N/A

50Wliu added some commits Nov 1, 2017

@50Wliu 50Wliu merged commit 6b9deee into master Nov 1, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-spec-reporter-enhancements branch Nov 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment