New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Shift from keydown events that terminate selection drags #16064

Merged
merged 1 commit into from Nov 1, 2017

Conversation

Projects
None yet
3 participants
@nathansobo
Contributor

nathansobo commented Nov 1, 2017

Fixes #16063

Follows up on #16060 by including Shift in the modifiers that are exempt from terminating a drag operation.

/cc @50Wliu @as-cii

@nathansobo nathansobo self-assigned this Nov 1, 2017

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Nov 1, 2017

Member

Thanks!

Member

50Wliu commented Nov 1, 2017

Thanks!

@Ben3eeE

This comment has been minimized.

Show comment
Hide comment
@Ben3eeE

Ben3eeE Nov 1, 2017

Member

I compared Atom to ST3 selection cancel keys:
Atom doesn't cancel on: ctrl, shift (soon), alt
ST3 doesn't cancel on: ctrl, shift, alt, caps lock, num lock

I can't figure out any specific reason to cancel or not on the lock keys.
I can't test meta or scroll lock because those keys don't work on my keyboard.

Member

Ben3eeE commented Nov 1, 2017

I compared Atom to ST3 selection cancel keys:
Atom doesn't cancel on: ctrl, shift (soon), alt
ST3 doesn't cancel on: ctrl, shift, alt, caps lock, num lock

I can't figure out any specific reason to cancel or not on the lock keys.
I can't test meta or scroll lock because those keys don't work on my keyboard.

@nathansobo

This comment has been minimized.

Show comment
Hide comment
@nathansobo

nathansobo Nov 1, 2017

Contributor

I can't figure out any specific reason to cancel or not on the lock keys.

I would guess that they're doing some kind of check for non-printing keys.

Contributor

nathansobo commented Nov 1, 2017

I can't figure out any specific reason to cancel or not on the lock keys.

I would guess that they're doing some kind of check for non-printing keys.

@nathansobo nathansobo merged commit b640765 into master Nov 1, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nathansobo nathansobo deleted the fix-shift-scroll-when-selecting branch Nov 1, 2017

nathansobo added a commit that referenced this pull request Nov 1, 2017

Merge pull request #16064 from atom/fix-shift-scroll-when-selecting
Exclude Shift from keydown events that terminate selection drags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment