New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select-word command between word and non-word chararacters #16075

Merged
merged 1 commit into from Nov 2, 2017

Conversation

Projects
None yet
2 participants
@nathansobo
Contributor

nathansobo commented Nov 2, 2017

In #15776, we accidentally stopped passing an option to the Cursor.wordRegExp method that caused us to prefer word characters when selecting words at a boundary between word and non-word characters.

This is only on master so glad we caught it before the next release.

/cc @maxbrunsfeld

Fix select-word command between word and non-word chararacters
In #15776, we accidentally stopped passing an option to the wordRegExp
method that caused us to prefer word characters when selecting words at
a boundary between word and non-word characters.

@nathansobo nathansobo self-assigned this Nov 2, 2017

@maxbrunsfeld

This comment has been minimized.

Show comment
Hide comment
@maxbrunsfeld

maxbrunsfeld Nov 2, 2017

Contributor

🙇 Thanks for fixing this!

Contributor

maxbrunsfeld commented Nov 2, 2017

🙇 Thanks for fixing this!

@maxbrunsfeld

This comment has been minimized.

Show comment
Hide comment
@maxbrunsfeld

maxbrunsfeld Nov 2, 2017

Contributor

Looks like the appveyor failure is a flake:

  1) AtomApplication "after each" hook for "does not reopen any previously opened windows when launched with no path and `core.restorePreviousWindowsOnStart` is no":
     Error: timeout of 60000ms exceeded. Ensure the done() callback is being called in this test.
      at Timeout.<anonymous> (C:\projects\atom\node_modules\mocha\lib\runnable.js:226:19)

Filed as #16079 and added to the reactive queue.

Contributor

maxbrunsfeld commented Nov 2, 2017

Looks like the appveyor failure is a flake:

  1) AtomApplication "after each" hook for "does not reopen any previously opened windows when launched with no path and `core.restorePreviousWindowsOnStart` is no":
     Error: timeout of 60000ms exceeded. Ensure the done() callback is being called in this test.
      at Timeout.<anonymous> (C:\projects\atom\node_modules\mocha\lib\runnable.js:226:19)

Filed as #16079 and added to the reactive queue.

@nathansobo nathansobo merged commit d0587a0 into master Nov 2, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nathansobo nathansobo deleted the fix-select-word branch Nov 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment