Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Judge resize of overlay by contentRect changing #16083
In this fix, we store the previous
@DavidLGoldberg thanks for reporting this bug and the work to help reproduce it on various builds!
Nov 2, 2017
referenced this pull request
Nov 2, 2017
Unfortunately guys, My app is still in a state of disarray.
Oddly it still works with the baby blue dev build OR any other build with
If it were only working with just the
Here's a bit more description:
Oh very sorry I'll check as soon as I get home! When will that go live?…
On Tue, Nov 7, 2017, 6:43 PM Wliu ***@***.***> wrote: @DavidLGoldberg <https://github.com/davidlgoldberg> the commit indicates that this fix is only in Atom 1.23.0-beta0 and later...have you tried that version? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16083 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAjTr-9sb5xgGteek0rCTrKiGfkHRj5aks5s0Os7gaJpZM4QQXsA> .
I tested on the Atom 1.23.0-beta0 and it works smoothly. Thanks for catching that @50Wliu .
I launched a 4.1.0 with a small little feature / fix and a yellow warning notification explaining the situation.
BTW, I put the notification object on the package's constructor / activation. I guess this will trigger for any new windows / reloads, but it's pretty easy to dismiss.
Is there a built in way to have this show once and only once to users? I didn't want to start fumbling with localStorage or any of that, but could it be done?
Would this be a useful feature to add into Atom's core notifications if I can get around to it?
Actually I kind of like the idea of being able to push these things to some managed bulletin but I know there are security concerns / limitations. It'd be really cool if it just read from any GH issue tagged with a certain tag :-p
Yeah, that's a great idea. Some kind of way of identifying a notification and requesting that it only runs once would be a good feature. I'll be interested to hear your thoughts on the design.
Ok, so this might sound unbelievable with my limited Atom expertise (I have a hard time believing it myself) but I believe there is a much bigger issue at play.
This may have started since I did a local build of atom (with baby blue icon, I love that by the way).
But I did an install using the downloadable executable from atom.io and now have the good ole stable green icon for both
The weird thing is though that everytime I do
Atom beta NON dev mode also of course works because it has the fix.
Is this all just a problem with my machine?
I only really have one dev env at the moment unfortunately.
If one of you could do
Right? What do I have confused?
(FYI: You have to perform a full jump now to see the 2nd iteration of the performance issue.)